[v1] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup

[PATCH] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup

Posted by Fabrice Gasnier 11 months, 1 week ago

From: Alexandre Torgue <alexandre.torgue@foss.st.com>

"wakeup-source" property describes a device which has wakeup capability
but should not force this device as a wakeup source.

Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 drivers/clocksource/timer-stm32-lp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c
index 96d975adf7a4..f08baa6720f8 100644
--- a/drivers/clocksource/timer-stm32-lp.c
+++ b/drivers/clocksource/timer-stm32-lp.c
@@ -186,9 +186,7 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev)
 	}
 
 	if (of_property_read_bool(pdev->dev.parent->of_node, "wakeup-source")) {
-		ret = device_init_wakeup(&pdev->dev, true);
-		if (ret)
-			goto out_clk_disable;
+		device_set_wakeup_capable(&pdev->dev, true);
 
 		ret = dev_pm_set_wake_irq(&pdev->dev, irq);
 		if (ret)
-- 
2.25.1

Re: [PATCH] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup

Posted by Daniel Lezcano 11 months, 1 week ago

On 05/03/2025 13:51, Fabrice Gasnier wrote:
> From: Alexandre Torgue <alexandre.torgue@foss.st.com>
> 
> "wakeup-source" property describes a device which has wakeup capability
> but should not force this device as a wakeup source.

Is that a fix to be carried on ?

> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
>   drivers/clocksource/timer-stm32-lp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c
> index 96d975adf7a4..f08baa6720f8 100644
> --- a/drivers/clocksource/timer-stm32-lp.c
> +++ b/drivers/clocksource/timer-stm32-lp.c
> @@ -186,9 +186,7 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev)
>   	}
>   
>   	if (of_property_read_bool(pdev->dev.parent->of_node, "wakeup-source")) {
> -		ret = device_init_wakeup(&pdev->dev, true);
> -		if (ret)
> -			goto out_clk_disable;
> +		device_set_wakeup_capable(&pdev->dev, true);
>   
>   		ret = dev_pm_set_wake_irq(&pdev->dev, irq);
>   		if (ret)


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] clocksource: stm32-lptimer: use wakeup capable instead of init wakeup

Posted by Fabrice Gasnier 11 months, 1 week ago

On 3/5/25 18:23, Daniel Lezcano wrote:
> On 05/03/2025 13:51, Fabrice Gasnier wrote:
>> From: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> "wakeup-source" property describes a device which has wakeup capability
>> but should not force this device as a wakeup source.
> 
> Is that a fix to be carried on ?

Hi Daniel,

Thanks for reviewing,
I just have sent a V2 with Fixes tag, and have CC'ed stable.

Please review there,
Best Regards,
Fabrice

Fixes: 48b41c5e2de6 ("clocksource: Add Low Power STM32 timers driver")
> 
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>> ---
>>   drivers/clocksource/timer-stm32-lp.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-stm32-lp.c
>> b/drivers/clocksource/timer-stm32-lp.c
>> index 96d975adf7a4..f08baa6720f8 100644
>> --- a/drivers/clocksource/timer-stm32-lp.c
>> +++ b/drivers/clocksource/timer-stm32-lp.c
>> @@ -186,9 +186,7 @@ static int stm32_clkevent_lp_probe(struct
>> platform_device *pdev)
>>       }
>>         if (of_property_read_bool(pdev->dev.parent->of_node,
>> "wakeup-source")) {
>> -        ret = device_init_wakeup(&pdev->dev, true);
>> -        if (ret)
>> -            goto out_clk_disable;
>> +        device_set_wakeup_capable(&pdev->dev, true);
>>             ret = dev_pm_set_wake_irq(&pdev->dev, irq);
>>           if (ret)
> 
>