drm/sti: fix inconsistent indenting warning

[PATCH] drm/sti: fix inconsistent indenting warning

Posted by Charles Han 11 months, 1 week ago

Fix below inconsistent indenting smatch warning.
smatch warnings:
drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting

Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/gpu/drm/sti/sti_hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 14fdc00d2ba0..6c9a49146f44 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -693,7 +693,7 @@ static int sti_hda_bind(struct device *dev, struct device *master, void *data)
 
 	connector->hda = hda;
 
-		bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
+	bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
 	if (!bridge)
 		return -ENOMEM;
 
-- 
2.43.0

Re: [PATCH] drm/sti: fix inconsistent indenting warning

Posted by Raphaël Gallais-Pou 11 months, 1 week ago


Le 05/03/2025 à 11:16, Charles Han a écrit :
> Fix below inconsistent indenting smatch warning.
> smatch warnings:
> drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting
> 
> Signed-off-by: Charles Han <hanchunchao@inspur.com>

Hi,

Acked-by: Raphaël Gallais-Pou <rgallaispou@gmail.com>

Thanks,
Raphaël
> ---
>   drivers/gpu/drm/sti/sti_hda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
> index 14fdc00d2ba0..6c9a49146f44 100644
> --- a/drivers/gpu/drm/sti/sti_hda.c
> +++ b/drivers/gpu/drm/sti/sti_hda.c
> @@ -693,7 +693,7 @@ static int sti_hda_bind(struct device *dev, struct device *master, void *data)
>   
>   	connector->hda = hda;
>   
> -		bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
> +	bridge = devm_kzalloc(dev, sizeof(*bridge), GFP_KERNEL);
>   	if (!bridge)
>   		return -ENOMEM;
>

Re: [PATCH] drm/sti: fix inconsistent indenting warning

Posted by Raphael Gallais-Pou 10 months, 1 week ago


On 3/7/25 13:58, Raphaël Gallais-Pou wrote:
>
>
> Le 05/03/2025 à 11:16, Charles Han a écrit :
>> Fix below inconsistent indenting smatch warning.
>> smatch warnings:
>> drivers/gpu/drm/sti/sti_hda.c:696 sti_hda_bind() warn: inconsistent indenting
>>
>> Signed-off-by: Charles Han <hanchunchao@inspur.com>
>

Hi,

Applied on drm-misc-next.

Thanks,
Raphaël Gallais-Pou