The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP core.
The binding that it uses is slightly different from existing ones because
of the integration (clocks, resets).
Signed-off-by: Swathi K S <swathi.ks@samsung.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
index 6cadf24a575c..e9038d015cf0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
@@ -325,6 +325,10 @@ static const struct dwc_eth_dwmac_data tegra_eqos_data = {
.stmmac_clk_name = "slave_bus",
};
+static const struct dwc_eth_dwmac_data fsd_eqos_data = {
+ .stmmac_clk_name = "slave_bus",
+};
+
static int dwc_eth_dwmac_probe(struct platform_device *pdev)
{
const struct dwc_eth_dwmac_data *data;
@@ -365,7 +369,8 @@ static int dwc_eth_dwmac_probe(struct platform_device *pdev)
plat_dat->stmmac_clk = dwc_eth_find_clk(plat_dat,
data->stmmac_clk_name);
- ret = data->probe(pdev, plat_dat, &stmmac_res);
+ if (data->probe)
+ ret = data->probe(pdev, plat_dat, &stmmac_res);
if (ret < 0) {
dev_err_probe(&pdev->dev, ret, "failed to probe subdriver\n");
clk_bulk_disable_unprepare(plat_dat->num_clks, plat_dat->clks);
@@ -406,6 +411,7 @@ static void dwc_eth_dwmac_remove(struct platform_device *pdev)
static const struct of_device_id dwc_eth_dwmac_match[] = {
{ .compatible = "snps,dwc-qos-ethernet-4.10", .data = &dwc_qos_data },
{ .compatible = "nvidia,tegra186-eqos", .data = &tegra_eqos_data },
+ { .compatible = "tesla,fsd-ethqos", .data = &fsd_eqos_data },
{ }
};
MODULE_DEVICE_TABLE(of, dwc_eth_dwmac_match);
--
2.17.1On Wed, Mar 05, 2025 at 02:42:46PM +0530, Swathi K S wrote: > The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP core. > The binding that it uses is slightly different from existing ones because > of the integration (clocks, resets). > > Signed-off-by: Swathi K S <swathi.ks@samsung.com> This looks much better! Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
On Wed, Mar 05, 2025 at 02:43:52PM +0000, Russell King (Oracle) wrote: > On Wed, Mar 05, 2025 at 02:42:46PM +0530, Swathi K S wrote: > > The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP core. > > The binding that it uses is slightly different from existing ones because > > of the integration (clocks, resets). > > > > Signed-off-by: Swathi K S <swathi.ks@samsung.com> > > This looks much better! > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > Thanks! Hi Swathi, Please can you test with my TX clock gating series applied ( https://lore.kernel.org/r/Z9FVHEf3uUqtKzyt@shell.armlinux.org.uk ) with STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP set as per the attached diff. Please let me know whether this passes your testing, so I know whether this platform supports it - please check that this results in a message in the kernel log indicating "tx_clk_stop = 1". Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
> -----Original Message----- > From: Russell King (Oracle) <linux@armlinux.org.uk> > Sent: 12 March 2025 23:27 > To: Swathi K S <swathi.ks@samsung.com> > Cc: krzk+dt@kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > robh@kernel.org; conor+dt@kernel.org; richardcochran@gmail.com; > mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; > netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; pankaj.dubey@samsung.com; > ravi.patel@samsung.com; gost.dev@samsung.com > Subject: Re: [PATCH v8 2/2] net: stmmac: dwc-qos: Add FSD EQoS support > > On Wed, Mar 05, 2025 at 02:43:52PM +0000, Russell King (Oracle) wrote: > > On Wed, Mar 05, 2025 at 02:42:46PM +0530, Swathi K S wrote: > > > The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP > core. > > > The binding that it uses is slightly different from existing ones > > > because of the integration (clocks, resets). > > > > > > Signed-off-by: Swathi K S <swathi.ks@samsung.com> > > > > This looks much better! > > > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > > Thanks! > > Hi Swathi, > > Please can you test with my TX clock gating series applied ( > https://lore.kernel.org/r/Z9FVHEf3uUqtKzyt@shell.armlinux.org.uk ) with > STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP set as per the attached diff. > Please let me know whether this passes your testing, so I know whether this > platform supports it - please check that this results in a message in the kernel > log indicating "tx_clk_stop = 1". Thanks. Hi Russell, Applied your patches and tested. It did not cause any functional issue, but at the same time, as EEE is not enabled in our HW, we cannot really test that particular functionality. Regards, Swathi > > -- > RMK's Patch system: https://protect2.fireeye.com/v1/url?k=23e12f6a- > 429cc5e9-23e0a425-74fe48600158-954ebfe080aed91e&q=1&e=40e60980- > bcfe-49e0-a9c9- > d9b87765f87c&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F > patches%2F > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
© 2016 - 2025 Red Hat, Inc.