1. Patchew
  2. linux
  3. [PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support
  4. View patch

[PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings

Swathi K S posted 2 patches 6 months, 2 weeks ago
[PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Swathi K S 6 months, 2 weeks ago 
Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
Ethernet YAML schema to enable the DT validation.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
Signed-off-by: Swathi K S <swathi.ks@samsung.com>
---
 .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
 .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
 2 files changed, 121 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 91e75eb3f329..c7004eaa8eae 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -102,6 +102,7 @@ properties:
         - snps,dwxgmac-2.10
         - starfive,jh7100-dwmac
         - starfive,jh7110-dwmac
+        - tesla,fsd-ethqos
         - thead,th1520-gmac
 
   reg:
@@ -126,7 +127,7 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 8
+    maxItems: 10
     additionalItems: true
     items:
       - description: GMAC main clock
@@ -138,7 +139,7 @@ properties:
 
   clock-names:
     minItems: 1
-    maxItems: 8
+    maxItems: 10
     additionalItems: true
     contains:
       enum:
diff --git a/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml b/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
new file mode 100644
index 000000000000..dd7481bb16e5
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
@@ -0,0 +1,118 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/tesla,fsd-ethqos.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: FSD Ethernet Quality of Service
+
+maintainers:
+  - Swathi K S <swathi.ks@samsung.com>
+
+description:
+  Tesla ethernet devices based on dwmmac support Gigabit ethernet.
+
+allOf:
+  - $ref: snps,dwmac.yaml#
+
+properties:
+  compatible:
+    const: tesla,fsd-ethqos
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: macirq
+
+  clocks:
+    minItems: 5
+    items:
+      - description: PTP clock
+      - description: Master bus clock
+      - description: Slave bus clock
+      - description: MAC TX clock
+      - description: MAC RX clock
+      - description: Master2 bus clock
+      - description: Slave2 bus clock
+      - description: RX MUX clock
+      - description: PHY RX clock
+      - description: PERIC RGMII clock
+
+  clock-names:
+    minItems: 5
+    items:
+      - const: ptp_ref
+      - const: master_bus
+      - const: slave_bus
+      - const: tx
+      - const: rx
+      - const: master2_bus
+      - const: slave2_bus
+      - const: eqos_rxclk_mux
+      - const: eqos_phyrxclk
+      - const: dout_peric_rgmii_clk
+
+  iommus:
+    maxItems: 1
+
+  phy-mode:
+    enum:
+      - rgmii
+      - rgmii-id
+      - rgmii-rxid
+      - rgmii-txid
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - iommus
+  - phy-mode
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/fsd-clk.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+        ethernet1: ethernet@14300000 {
+            compatible = "tesla,fsd-ethqos";
+            reg = <0x0 0x14300000 0x0 0x10000>;
+            interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
+            interrupt-names = "macirq";
+            clocks = <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_PTP_REF_I>,
+                     <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_ACLK_I>,
+                     <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_HCLK_I>,
+                     <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_RGMII_CLK_I>,
+                     <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_RX_I>,
+                     <&clock_peric PERIC_BUS_D_PERIC_IPCLKPORT_EQOSCLK>,
+                     <&clock_peric PERIC_BUS_P_PERIC_IPCLKPORT_EQOSCLK>,
+                     <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
+                     <&clock_peric PERIC_EQOS_PHYRXCLK>,
+                     <&clock_peric PERIC_DOUT_RGMII_CLK>;
+            clock-names = "ptp_ref", "master_bus", "slave_bus","tx",
+                          "rx", "master2_bus", "slave2_bus", "eqos_rxclk_mux",
+                          "eqos_phyrxclk","dout_peric_rgmii_clk";
+            assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
+                              <&clock_peric PERIC_EQOS_PHYRXCLK>;
+            assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;
+            pinctrl-names = "default";
+            pinctrl-0 = <&eth1_tx_clk>, <&eth1_tx_data>, <&eth1_tx_ctrl>,
+                        <&eth1_phy_intr>, <&eth1_rx_clk>, <&eth1_rx_data>,
+                        <&eth1_rx_ctrl>, <&eth1_mdio>;
+            iommus = <&smmu_peric 0x0 0x1>;
+            phy-mode = "rgmii-id";
+        };
+    };
+
+...
-- 
2.17.1
Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Krzysztof Kozlowski 6 months, 1 week ago 
On 05/03/2025 10:12, Swathi K S wrote:
> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> Ethernet YAML schema to enable the DT validation.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Krzysztof Kozlowski 6 months, 1 week ago 
On 05/03/2025 10:12, Swathi K S wrote:
> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> Ethernet YAML schema to enable the DT validation.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
>  .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
>  2 files changed, 121 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
> 

I tried and did not see any differences, so point me exactly to any
difference in the binding (binding!) which would justify dropping review?

Best regards,
Krzysztof
RE: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Swathi K S 6 months, 1 week ago 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 06 March 2025 12:45
> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> gost.dev@samsung.com
> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
> bindings
> 
> On 05/03/2025 10:12, Swathi K S wrote:
> > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> > Ethernet YAML schema to enable the DT validation.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> > Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> > ---
> >  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
> >  .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
> >  2 files changed, 121 insertions(+), 2 deletions(-)  create mode
> > 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
> >
> 
> I tried and did not see any differences, so point me exactly to any difference
> in the binding (binding!) which would justify dropping review?

Added the following in the example given in DT binding doc:

assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
                                <&clock_peric PERIC_EQOS_PHYRXCLK>;
assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;

Given the significance of these changes, I assumed the changes need to be reviewed again.
That was why the tag was removed. Please correct me if I am wrong and provide your feedback on this patch.

- Swathi

> 
> Best regards,
> Krzysztof
Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Krzysztof Kozlowski 6 months, 1 week ago 
On 06/03/2025 08:44, Swathi K S wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 06 March 2025 12:45
>> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
>> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
>> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
>> conor+dt@kernel.org; richardcochran@gmail.com;
>> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
>> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
>> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
>> gost.dev@samsung.com
>> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
>> bindings
>>
>> On 05/03/2025 10:12, Swathi K S wrote:
>>> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
>>> Ethernet YAML schema to enable the DT validation.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
>>> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
>>> ---
>>>  .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
>>>  .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
>>>  2 files changed, 121 insertions(+), 2 deletions(-)  create mode
>>> 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
>>>
>>
>> I tried and did not see any differences, so point me exactly to any difference
>> in the binding (binding!) which would justify dropping review?
> 
> Added the following in the example given in DT binding doc:

OK, but that's an example, not the binding, so no new properties in the
binding.

> 
> assigned-clocks = <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
>                                 <&clock_peric PERIC_EQOS_PHYRXCLK>;
> assigned-clock-parents = <&clock_peric PERIC_EQOS_PHYRXCLK>;
> 
> Given the significance of these changes, I assumed the changes need to be reviewed again.

Adding standard properties to the example is not significant change. It
is really a minor change.



Best regards,
Krzysztof
Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Krzysztof Kozlowski 6 months, 2 weeks ago 
On 05/03/2025 10:12, Swathi K S wrote:
> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> Ethernet YAML schema to enable the DT validation.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Swathi K S <swathi.ks@samsung.com>

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
RE: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Swathi K S 6 months, 1 week ago 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 05 March 2025 21:12
> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> gost.dev@samsung.com
> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
> bindings
> 
> On 05/03/2025 10:12, Swathi K S wrote:
> > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
> > Ethernet YAML schema to enable the DT validation.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> > Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless patch
> changed significantly (e.g. new properties added to the DT bindings). Tag is
> "received", when provided in a message replied to you on the mailing list.
> Tools like b4 can help here. However, there's no need to repost patches
> *only* to add the tags. The upstream maintainer will do that for tags
> received on the version they apply.
> 
> Please read:
> https://protect2.fireeye.com/v1/url?k=19972162-781c345b-1996aa2d-
> 000babffae10-7bd6b1a1d78b210b&q=1&e=94dcc3a6-5303-441a-8c1e-
> de696b216f86&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
> rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
> patches.rst%23L577
> 
> If a tag was not added on purpose, please state why and what changed.

Hi Krzysztof, 
As per a review comment received from Russell, I had added 2 new properties to the DT - assigned-clocks and assigned-clock-parents properties. 
The example in the DT binding reflects the same.
I felt it wouldn't be fair to add 'Reviewed-by' tag without you reviewing the updates again.
But I should have mentioned that in cover letter and apologies for missing to do that.

- Swathi

> </form letter>
> 
> Best regards,
> Krzysztof
Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Krzysztof Kozlowski 6 months, 1 week ago 
On 06/03/2025 04:40, Swathi K S wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 05 March 2025 21:12
>> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
>> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
>> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
>> conor+dt@kernel.org; richardcochran@gmail.com;
>> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
>> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
>> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
>> gost.dev@samsung.com
>> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
>> bindings
>>
>> On 05/03/2025 10:12, Swathi K S wrote:
>>> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD
>>> Ethernet YAML schema to enable the DT validation.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
>>> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions of patchset, under or above your Signed-off-by tag, unless patch
>> changed significantly (e.g. new properties added to the DT bindings). Tag is
>> "received", when provided in a message replied to you on the mailing list.
>> Tools like b4 can help here. However, there's no need to repost patches
>> *only* to add the tags. The upstream maintainer will do that for tags
>> received on the version they apply.
>>
>> Please read:
>> https://protect2.fireeye.com/v1/url?k=19972162-781c345b-1996aa2d-
>> 000babffae10-7bd6b1a1d78b210b&q=1&e=94dcc3a6-5303-441a-8c1e-
>> de696b216f86&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
>> rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
>> patches.rst%23L577
>>
>> If a tag was not added on purpose, please state why and what changed.
> 
> Hi Krzysztof, 
> As per a review comment received from Russell, I had added 2 new properties to the DT - assigned-clocks and assigned-clock-parents properties. 
> The example in the DT binding reflects the same.
> I felt it wouldn't be fair to add 'Reviewed-by' tag without you reviewing the updates again.
> But I should have mentioned that in cover letter and apologies for missing to do that.
Nothing in changelog explained new properties. Nothing mentioned
dropping tag, which you always must explicitly say.

Best regards,
Krzysztof
RE: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree bindings
Posted by Swathi K S 6 months, 1 week ago 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 06 March 2025 12:35
> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> gost.dev@samsung.com
> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device tree
> bindings
> 
> On 06/03/2025 04:40, Swathi K S wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 05 March 2025 21:12
> >> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
> >> andrew+netdev@lunn.ch; davem@davemloft.net;
> edumazet@google.com;
> >> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
> >> conor+dt@kernel.org; richardcochran@gmail.com;
> >> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
> >> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-stm32@st-md-
> mailman.stormreply.com;
> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> >> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> >> gost.dev@samsung.com
> >> Subject: Re: [PATCH v8 1/2] dt-bindings: net: Add FSD EQoS device
> >> tree bindings
> >>
> >> On 05/03/2025 10:12, Swathi K S wrote:
> >>> Add FSD Ethernet compatible in Synopsys dt-bindings document. Add
> >>> FSD Ethernet YAML schema to enable the DT validation.
> >>>
> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >>> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> >>> Signed-off-by: Swathi K S <swathi.ks@samsung.com>
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It looks like you received a tag and forgot to add it.
> >>
> >> If you do not know the process, here is a short explanation:
> >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> >> versions of patchset, under or above your Signed-off-by tag, unless
> >> patch changed significantly (e.g. new properties added to the DT
> >> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list.
> >> Tools like b4 can help here. However, there's no need to repost
> >> patches
> >> *only* to add the tags. The upstream maintainer will do that for tags
> >> received on the version they apply.
> >>
> >> Please read:
> >> https://protect2.fireeye.com/v1/url?k=19972162-781c345b-1996aa2d-
> >> 000babffae10-7bd6b1a1d78b210b&q=1&e=94dcc3a6-5303-441a-8c1e-
> >> de696b216f86&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
> >> rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
> >> patches.rst%23L577
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> >
> > Hi Krzysztof,
> > As per a review comment received from Russell, I had added 2 new
> properties to the DT - assigned-clocks and assigned-clock-parents properties.
> > The example in the DT binding reflects the same.
> > I felt it wouldn't be fair to add 'Reviewed-by' tag without you reviewing the
> updates again.
> > But I should have mentioned that in cover letter and apologies for missing
> to do that.
> Nothing in changelog explained new properties. Nothing mentioned

Had mentioned under 'changes since v7' in the cover letter patch where I had mentioned about addressing Russell's comment and corresponding DT binding example changes of setting clock tree in DT.

- Swathi 

> dropping tag, which you always must explicitly say.
> 
> Best regards,
> Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.