[PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support

Swathi K S posted 2 patches 6 months, 2 weeks ago
.../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
.../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
.../stmicro/stmmac/dwmac-dwc-qos-eth.c        |   8 +-
3 files changed, 128 insertions(+), 3 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml
[PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support
Posted by Swathi K S 6 months, 2 weeks ago
FSD platform has two instances of EQoS IP, one is in FSYS0 block and
another one is in PERIC block. This patch series add required DT binding
and platform driver specific changes for the same.

Changes since v1:
1. Updated dwc_eqos_setup_rxclock() function as per the review comments
given by Andrew.

Changes since v2:
1. Addressed all the review comments suggested by Krzysztof with respect to
DT binding file.
2. Added SOB Swathi.

Changes since v3:
1. Avoided using alias-id to configure the HW.
2. Modified the clock implementation.

Changes since v4:
1. Avoided switching between internal and external clocks for every open/
close.
2. Addressed the review comments on DT bindings

Changes since v5:
1. Addressed the review comment on correcting the intendation.
2. Corrected the compatible name in dt-binding file.
3. Listed and described the clocks in dt-binding.
4. Modified FSD probe as per the changes in the refactoring patch given
below: https://lore.kernel.org/netdev/20250207121849.55815-1-swathi.ks@samsung.com/

Changes since v6:
1. Addressed review comments by Krzysztof on dt-binding file regarding
clock-names property
2. Corrected indentation issue in dt-binding
3. Addressed Andrew's comment on listing phy-modes.

Changes since v7:
1. Modified the example given in DT binding as per Russell's review
comment on setting clock tree in DT
2. Removed FSD probe since clock tree setting would be done via DT.

Here is the link to v7 patches for reference:
https://lore.kernel.org/netdev/20250220043712.31966-1-swathi.ks@samsung.com/

Swathi K S (2):
  dt-bindings: net: Add FSD EQoS device tree bindings
  net: stmmac: dwc-qos: Add FSD EQoS support

 .../devicetree/bindings/net/snps,dwmac.yaml   |   5 +-
 .../bindings/net/tesla,fsd-ethqos.yaml        | 118 ++++++++++++++++++
 .../stmicro/stmmac/dwmac-dwc-qos-eth.c        |   8 +-
 3 files changed, 128 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/tesla,fsd-ethqos.yaml

-- 
2.17.1
Re: [PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support
Posted by Krzysztof Kozlowski 6 months, 1 week ago
On 05/03/2025 10:12, Swathi K S wrote:
> FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> another one is in PERIC block. This patch series add required DT binding
> and platform driver specific changes for the same.
> 
> Changes since v1:
> 1. Updated dwc_eqos_setup_rxclock() function as per the review comments
> given by Andrew.
> 
Please stop referencing some other threads in your email headers via
"References". This is neither necessary nor helping our tools. I can
never compare your patches because this makes b4 busy 100%:

b4 diff -C '<20250305091246.106626-2-swathi.ks@samsung.com>'
Grabbing thread from
lore.kernel.org/all/20250305091246.106626-2-swathi.ks@samsung.com/t.mbox.gz
Checking for older revisions
  Added from v7: 3 patches
---
Analyzing 86 messages in the thread
Preparing fake-am for v7: dt-bindings: net: Add FSD EQoS device tree
bindings
<never ends, 100% CPU>

Best regards,
Krzysztof
RE: [PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support
Posted by Swathi K S 6 months, 1 week ago

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 06 March 2025 12:40
> To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; robh@kernel.org;
> conor+dt@kernel.org; richardcochran@gmail.com;
> mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com
> Cc: rmk+kernel@armlinux.org.uk; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com;
> gost.dev@samsung.com; tools@linux.kernel.org
> Subject: Re: [PATCH v8 0/2] net: stmmac: dwc-qos: Add FSD EQoS support
> 
> On 05/03/2025 10:12, Swathi K S wrote:
> > FSD platform has two instances of EQoS IP, one is in FSYS0 block and
> > another one is in PERIC block. This patch series add required DT
> > binding and platform driver specific changes for the same.
> >
> > Changes since v1:
> > 1. Updated dwc_eqos_setup_rxclock() function as per the review
> > comments given by Andrew.
> >
> Please stop referencing some other threads in your email headers via
> "References". This is neither necessary nor helping our tools. I can never
> compare your patches because this makes b4 busy 100%:

Will take care in future

- Swathi

> 
> b4 diff -C '<20250305091246.106626-2-swathi.ks@samsung.com>'
> Grabbing thread from
> lore.kernel.org/all/20250305091246.106626-2-
> swathi.ks@samsung.com/t.mbox.gz
> Checking for older revisions
>   Added from v7: 3 patches
> ---
> Analyzing 86 messages in the thread
> Preparing fake-am for v7: dt-bindings: net: Add FSD EQoS device tree
> bindings <never ends, 100% CPU>
> 
> Best regards,
> Krzysztof