media: imx-mipi-csis: Fix v4l2 mbus frame descriptor type

[PATCH] media: imx-mipi-csis: Fix v4l2 mbus frame descriptor type

Posted by Inbaraj E 11 months, 1 week ago

For MIPI CSI2 v4l2 mbus frame descriptor type should be set to
V4L2_MBUS_FRAME_DESC_TYPE_CSI2. Now frame descriptor type is set to
V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL. So changing the frame descriptor
type to V4L2_MBUS_FRAME_DESC_TYPE_CSI2.

Fixes: d200de90de2a0 ("media: imx: imx-mipi-csis: Implement the .get_frame_desc() operation")
Signed-off-by: Inbaraj E <inbaraj.e@samsung.com>
---
 drivers/media/platform/nxp/imx-mipi-csis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
index 29523bb84d95..bb6550bed230 100644
--- a/drivers/media/platform/nxp/imx-mipi-csis.c
+++ b/drivers/media/platform/nxp/imx-mipi-csis.c
@@ -1137,7 +1137,7 @@ static int mipi_csis_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
 	if (!csis_fmt)
 		return -EPIPE;
 
-	fd->type = V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL;
+	fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
 	fd->num_entries = 1;
 
 	entry->flags = 0;
-- 
2.17.1

Re: [PATCH] media: imx-mipi-csis: Fix v4l2 mbus frame descriptor type

Posted by Laurent Pinchart 11 months, 1 week ago

Hi Inbaraj,

Thank you for the patch.

On Wed, Mar 05, 2025 at 11:26:55AM +0530, Inbaraj E wrote:
> For MIPI CSI2 v4l2 mbus frame descriptor type should be set to
> V4L2_MBUS_FRAME_DESC_TYPE_CSI2. Now frame descriptor type is set to
> V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL. So changing the frame descriptor
> type to V4L2_MBUS_FRAME_DESC_TYPE_CSI2.

The frame descriptor describes the bus on the *output* of the CSIS.
That's not CSI-2 anymore, but a parallel bus.

Is this patch fixing an actual issue ?

> Fixes: d200de90de2a0 ("media: imx: imx-mipi-csis: Implement the .get_frame_desc() operation")
> Signed-off-by: Inbaraj E <inbaraj.e@samsung.com>
> ---
>  drivers/media/platform/nxp/imx-mipi-csis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
> index 29523bb84d95..bb6550bed230 100644
> --- a/drivers/media/platform/nxp/imx-mipi-csis.c
> +++ b/drivers/media/platform/nxp/imx-mipi-csis.c
> @@ -1137,7 +1137,7 @@ static int mipi_csis_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
>  	if (!csis_fmt)
>  		return -EPIPE;
>  
> -	fd->type = V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL;
> +	fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
>  	fd->num_entries = 1;
>  
>  	entry->flags = 0;

-- 
Regards,

Laurent Pinchart