spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI

[PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI

Posted by Inochi Amaoto 11 months, 1 week ago

The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
Add ACPI ID for it.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/spi/spi-dw-mmio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index f0f576fac77a..70fdc4b6de9e 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -426,6 +426,7 @@ MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
 	{"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
+	{"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
 	{},
 };
 MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
-- 
2.48.1

Re: [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI

Posted by Inochi Amaoto 11 months, 1 week ago

On Tue, Mar 04, 2025 at 03:02:10PM +0800, Inochi Amaoto wrote:
> The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
> Add ACPI ID for it.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  drivers/spi/spi-dw-mmio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index f0f576fac77a..70fdc4b6de9e 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -426,6 +426,7 @@ MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
>  	{"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
> +	{"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
>  	{},
>  };
>  MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> -- 
> 2.48.1
> 

Drop this patch for now as the ACPI id is not registed.

Regards,
Inochi

Re: [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI

Posted by Andy Shevchenko 11 months, 1 week ago

On Tue, Mar 04, 2025 at 07:48:42PM +0800, Inochi Amaoto wrote:
> On Tue, Mar 04, 2025 at 03:02:10PM +0800, Inochi Amaoto wrote:
> > The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
> > Add ACPI ID for it.

...

> >  static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
> >  	{"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
> > +	{"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
> >  	{},
> >  };

> Drop this patch for now as the ACPI id is not registed.

Right, more details are in another thread:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com

And here is a formal NAK from me.

Thanks, Inochi, to take this into account!

-- 
With Best Regards,
Andy Shevchenko