serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

[PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

Posted by Inochi Amaoto 11 months, 1 week ago

The UART on Sophgo SG2044 can be enumerated via ACPI.
Add ACPI ID for it.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/tty/serial/8250/8250_dw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 6afcf27db3b8..031ca1a7155b 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -785,6 +785,7 @@ static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "INT3434", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "INT3435", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "INTC10EE", (kernel_ulong_t)&dw8250_dw_apb },
+	{ "SOPH0002", (kernel_ulong_t)&dw8250_skip_set_rate_data },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
-- 
2.48.1

Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

Posted by Andy Shevchenko 11 months, 1 week ago

On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> The UART on Sophgo SG2044 can be enumerated via ACPI.
> Add ACPI ID for it.

This is fake ACPI ID. Please work with a vendor to issue the proper one.
Vendor ACPI ID registry has no records on Sophgo:
https://uefi.org/ACPI_ID_List?acpi_search=SophGo

NAK.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

Posted by Andy Shevchenko 11 months, 1 week ago

On Tue, Mar 04, 2025 at 01:36:47PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> > The UART on Sophgo SG2044 can be enumerated via ACPI.
> > Add ACPI ID for it.
> 
> This is fake ACPI ID. Please work with a vendor to issue the proper one.
> Vendor ACPI ID registry has no records on Sophgo:
> https://uefi.org/ACPI_ID_List?acpi_search=SophGo
> 
> NAK.

FWIW, the I2C thread has more insights and details:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

Posted by Inochi Amaoto 11 months, 1 week ago

On Tue, Mar 04, 2025 at 01:48:57PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 01:36:47PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> > > The UART on Sophgo SG2044 can be enumerated via ACPI.
> > > Add ACPI ID for it.
> > 
> > This is fake ACPI ID. Please work with a vendor to issue the proper one.
> > Vendor ACPI ID registry has no records on Sophgo:
> > https://uefi.org/ACPI_ID_List?acpi_search=SophGo
> > 
> > NAK.
> 
> FWIW, the I2C thread has more insights and details:
> https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
> 

Thanks for your info, I have seen the feedback.

Regards,
Inochi