rtc: pcf85063: replace dev_err+return with return dev_err_probe

[PATCH] rtc: pcf85063: replace dev_err+return with return dev_err_probe

Posted by Maud Spierings via B4 Relay 11 months, 1 week ago

From: Maud Spierings <maudspierings@gocontroll.com>

Replace the dev_err plus return combo with return dev_err_probe() this
actually communicates the error type when it occurs and helps debugging
hardware issues.

Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
I had some issues with a pcf85063a this change helped debugging it,
hopefully it can help someone else in the future as well.
---
 drivers/rtc/rtc-pcf85063.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index 905986c616559b87826d1102dbc25614f7dcbcbb..650e45876be5e88d96b0ffabaab204168c8d355c 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -591,8 +591,7 @@ static int pcf85063_probe(struct i2c_client *client)
 
 	err = regmap_read(pcf85063->regmap, PCF85063_REG_CTRL1, &tmp);
 	if (err) {
-		dev_err(&client->dev, "RTC chip is not present\n");
-		return err;
+		return dev_err_probe(&client->dev, err, "RTC chip is not present\n");
 	}
 
 	pcf85063->rtc = devm_rtc_allocate_device(&client->dev);

---
base-commit: cd3215bbcb9d4321def93fea6cfad4d5b42b9d1d
change-id: 20250304-rtc_dev_err_probe-ae3268fec5bd

Best regards,
-- 
Maud Spierings <maudspierings@gocontroll.com>

Re: [PATCH] rtc: pcf85063: replace dev_err+return with return dev_err_probe

Posted by Alexandre Belloni 10 months, 1 week ago

On Tue, 04 Mar 2025 09:14:52 +0100, Maud Spierings wrote:
> Replace the dev_err plus return combo with return dev_err_probe() this
> actually communicates the error type when it occurs and helps debugging
> hardware issues.
> 
> 

Applied, thanks!

[1/1] rtc: pcf85063: replace dev_err+return with return dev_err_probe
      https://git.kernel.org/abelloni/c/119e90a3a64d

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com