e1000: Adicionado const para melhorar a segurança do código

[PATCH] e1000: Adicionado const para melhorar a segurança do código

Posted by joaomboni 11 months, 1 week ago

Signed-off-by: joaomboni <joaoboni017@gmail.com>
---
 drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 3f089c3d47b2..96bc85f09aaf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -9,7 +9,7 @@
 #include <linux/if_vlan.h>
 
 char e1000_driver_name[] = "e1000";
-static char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
+static const char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
 static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel Corporation.";
 
 /* e1000_pci_tbl - PCI Device ID Table
-- 
2.48.1

Re: [PATCH] e1000: Adicionado const para melhorar a segurança do código

Posted by Andrew Lunn 11 months, 1 week ago

On Mon, Mar 03, 2025 at 10:11:55AM -0300, joaomboni wrote:
> Signed-off-by: joaomboni <joaoboni017@gmail.com>

Sorry, but the Subject: line needs to be in English.

And the name in Signed-off-by: needs to be a real name.

The code change itself looks sensible.

    Andrew

---
pw-bot: cr

Re: [PATCH] e1000: Adicionado const para melhorar asegurança do código

Posted by Jakub Kicinski 11 months, 1 week ago

On Mon, 3 Mar 2025 14:48:46 +0100 Andrew Lunn wrote:
> Sorry, but the Subject: line needs to be in English.
> 
> And the name in Signed-off-by: needs to be a real name.
> 
> The code change itself looks sensible.

If only we were also LLMs, not just humans, we could read commits 
in any language!