Like SG2042, SG2044 uses a similar msi controller to provide MSI
interrupt for PCIe controllers.
Add support for the SG2044 msi controller
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
.../bindings/interrupt-controller/sophgo,sg2042-msi.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
index e1ffd55fa7bf..f6b8b1d92f79 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml
@@ -18,7 +18,9 @@ allOf:
properties:
compatible:
- const: sophgo,sg2042-msi
+ enum:
+ - sophgo,sg2042-msi
+ - sophgo,sg2044-msi
reg:
items:
--
2.48.1
On Mon, Mar 03, 2025 at 07:16:46PM +0800, Inochi Amaoto wrote: > Like SG2042, SG2044 uses a similar msi controller to provide MSI > interrupt for PCIe controllers. In the future, could you mention the way in which they differ? "similar" could mean 99% the same but incompatible, or 90% the same but capable of using a fallback? Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Add support for the SG2044 msi controller > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > --- > .../bindings/interrupt-controller/sophgo,sg2042-msi.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml > index e1ffd55fa7bf..f6b8b1d92f79 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sophgo,sg2042-msi.yaml > @@ -18,7 +18,9 @@ allOf: > > properties: > compatible: > - const: sophgo,sg2042-msi > + enum: > + - sophgo,sg2042-msi > + - sophgo,sg2044-msi > > reg: > items: > -- > 2.48.1 >
On Mon, Mar 03, 2025 at 04:29:53PM +0000, Conor Dooley wrote: > On Mon, Mar 03, 2025 at 07:16:46PM +0800, Inochi Amaoto wrote: > > Like SG2042, SG2044 uses a similar msi controller to provide MSI > > interrupt for PCIe controllers. > > In the future, could you mention the way in which they differ? > "similar" could mean 99% the same but incompatible, or 90% the same but > capable of using a fallback? > Acked-by: Conor Dooley <conor.dooley@microchip.com> > It is OK for me. The difference between these two controller are the number of MSI interrupts supports, and the way to mask/map MSI message. I will update the comment message for it. Regards, Inochi
© 2016 - 2026 Red Hat, Inc.