[PATCH v3 1/4] dt-bindings: input: touchscreen: edt-ft5x06: use unevaluatedProperties

Joel Selvaraj via B4 Relay posted 4 patches 11 months, 2 weeks ago
There is a newer version of this series
[PATCH v3 1/4] dt-bindings: input: touchscreen: edt-ft5x06: use unevaluatedProperties
Posted by Joel Selvaraj via B4 Relay 11 months, 2 weeks ago
From: Joel Selvaraj <foss@joelselvaraj.com>

In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech
FT8719 touchscreen is integrally connected to the display panel
(EBBG FT8719) and thus should be power sequenced together with display
panel using the panel property. Since the touchscreen controller uses
almost all the properties present in touchscreen.yaml, let's remove
additionalProperties: false and use unevaluatedProperties to include all
the properties including the needed panel property.

Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
---
 .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml        | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 70a922e213f2..ab821490284a 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -103,16 +103,9 @@ properties:
     minimum: 0
     maximum: 255
 
-  touchscreen-size-x: true
-  touchscreen-size-y: true
-  touchscreen-fuzz-x: true
-  touchscreen-fuzz-y: true
-  touchscreen-inverted-x: true
-  touchscreen-inverted-y: true
-  touchscreen-swapped-x-y: true
   interrupt-controller: true
 
-additionalProperties: false
+unevaluatedProperties: false
 
 required:
   - compatible

-- 
2.48.1
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: edt-ft5x06: use unevaluatedProperties
Posted by Krzysztof Kozlowski 11 months, 1 week ago
On Sat, Mar 01, 2025 at 05:43:07PM -0600, Joel Selvaraj wrote:
> In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech
> FT8719 touchscreen is integrally connected to the display panel
> (EBBG FT8719) and thus should be power sequenced together with display
> panel using the panel property. Since the touchscreen controller uses
> almost all the properties present in touchscreen.yaml, let's remove
> additionalProperties: false and use unevaluatedProperties to include all
> the properties including the needed panel property.
> 
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---
>  .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml        | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: edt-ft5x06: use unevaluatedProperties
Posted by Joel Selvaraj 11 months, 2 weeks ago
On Saturday, March 1st, 2025 at 5:43 PM, Joel Selvaraj via B4 Relay <devnull+foss.joelselvaraj.com@kernel.org> wrote:
> ...clipped...
> Since the touchscreen controller uses almost all the properties present in touchscreen.yaml...

Sorry, should have been "Since the edt-ft5x06 touchscreen binding document uses almost all the properties...".
I will wait for further review by others and will fix it v4. Or if it is acceptable with current commit message,
let me know.

Thanks,
Joel Selvaraj