[v2] Fixups for kernel maps insertion

[PATCH 0/6 v2] Fixups for kernel maps insertion

Posted by Arnaldo Carvalho de Melo 9 months, 3 weeks ago

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Hi Namhyung,

        Here are the patches from the recent session on fixing the build
when DEBUG=1 is used, please take a look.

        I think that since there are no reported problems and ended up
being a sizeable series, we better apply it to perf-tools-next,

Best Regards,

- Arnaldo

v2: Use map__set_kmap_maps() as suggested by Ian.

Arnaldo Carvalho de Melo (3):
  perf maps: Introduce map__set_kmap_maps() for kernel maps
  perf maps: Set the kmaps for newly created/added kernel maps
  perf maps: Add missing map__set_kmap_maps() when replacing a kernel map

Namhyung Kim (3):
  perf machine: Fixup kernel maps ends after adding extra maps
  perf maps: Fixup maps_by_name when modifying maps_by_address
  perf machine: Fix insertion of PERF_RECORD_KSYMBOL related kernel maps

 tools/perf/util/machine.c |  6 ++--
 tools/perf/util/maps.c    | 58 +++++++++++++++++++++++++++++++++------
 2 files changed, 52 insertions(+), 12 deletions(-)

-- 
2.48.1

Re: [PATCH 0/6 v2] Fixups for kernel maps insertion

Posted by Namhyung Kim 9 months, 2 weeks ago

On Fri, 28 Feb 2025 18:17:28 -0300, Arnaldo Carvalho de Melo wrote:
>         Here are the patches from the recent session on fixing the build
> when DEBUG=1 is used, please take a look.
> 
>         I think that since there are no reported problems and ended up
> being a sizeable series, we better apply it to perf-tools-next,
> 
> Best Regards,
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH 0/6 v2] Fixups for kernel maps insertion

Posted by Namhyung Kim 9 months, 3 weeks ago

On Fri, Feb 28, 2025 at 06:17:28PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Hi Namhyung,
> 
>         Here are the patches from the recent session on fixing the build
> when DEBUG=1 is used, please take a look.

Looks good.  It's more fine-grained than I expected. :)

> 
>         I think that since there are no reported problems and ended up
> being a sizeable series, we better apply it to perf-tools-next,

Sure, will add there.

Thanks,
Namhyung

> 
> Best Regards,
> 
> - Arnaldo
> 
> v2: Use map__set_kmap_maps() as suggested by Ian.
> 
> Arnaldo Carvalho de Melo (3):
>   perf maps: Introduce map__set_kmap_maps() for kernel maps
>   perf maps: Set the kmaps for newly created/added kernel maps
>   perf maps: Add missing map__set_kmap_maps() when replacing a kernel map
> 
> Namhyung Kim (3):
>   perf machine: Fixup kernel maps ends after adding extra maps
>   perf maps: Fixup maps_by_name when modifying maps_by_address
>   perf machine: Fix insertion of PERF_RECORD_KSYMBOL related kernel maps
> 
>  tools/perf/util/machine.c |  6 ++--
>  tools/perf/util/maps.c    | 58 +++++++++++++++++++++++++++++++++------
>  2 files changed, 52 insertions(+), 12 deletions(-)
> 
> -- 
> 2.48.1
>

Re: [PATCH 0/6 v2] Fixups for kernel maps insertion

Posted by Namhyung Kim 9 months, 3 weeks ago

On Fri, Feb 28, 2025 at 04:03:48PM -0800, Namhyung Kim wrote:
> On Fri, Feb 28, 2025 at 06:17:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > Hi Namhyung,
> > 
> >         Here are the patches from the recent session on fixing the build
> > when DEBUG=1 is used, please take a look.
> 
> Looks good.  It's more fine-grained than I expected. :)
> 
> > 
> >         I think that since there are no reported problems and ended up
> > being a sizeable series, we better apply it to perf-tools-next,
> 
> Sure, will add there.

Ian, are you ok with this now?

Thanks,
Namhyung

Re: [PATCH 0/6 v2] Fixups for kernel maps insertion

Posted by Ian Rogers 9 months, 2 weeks ago

On Mon, Mar 3, 2025 at 12:45 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Fri, Feb 28, 2025 at 04:03:48PM -0800, Namhyung Kim wrote:
> > On Fri, Feb 28, 2025 at 06:17:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > >
> > > Hi Namhyung,
> > >
> > >         Here are the patches from the recent session on fixing the build
> > > when DEBUG=1 is used, please take a look.
> >
> > Looks good.  It's more fine-grained than I expected. :)
> >
> > >
> > >         I think that since there are no reported problems and ended up
> > > being a sizeable series, we better apply it to perf-tools-next,
> >
> > Sure, will add there.
>
> Ian, are you ok with this now?

Yep, sorry for the delay.

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> Thanks,
> Namhyung
>