eth: fbnic: Cleanup macros and string function

[PATCH net-next 0/3] eth: fbnic: Cleanup macros and string function

Lee Trager posted 3 patches 11 months, 1 week ago

Download series mbox

drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 109 ++++++++++----------
drivers/net/ethernet/meta/fbnic/fbnic_fw.h  |   8 +-
drivers/net/ethernet/meta/fbnic/fbnic_tlv.c |  55 +++++++---
drivers/net/ethernet/meta/fbnic/fbnic_tlv.h |  39 ++-----
4 files changed, 110 insertions(+), 101 deletions(-)

Expand all Fold all

[PATCH net-next 0/3] eth: fbnic: Cleanup macros and string function

Posted by Lee Trager 11 months, 1 week ago

We have received some feedback that the macros we use for reading FW mailbox
attributes are too large in scope and confusing to understanding. Additionally
the string function did not provide errors allowing it to silently succeed.
This patch set fixes theses issues.

Lee Trager (3):
  eth: fbnic: Prepend TSENE FW fields with FBNIC_FW
  eth: fbnic: Update fbnic_tlv_attr_get_string() to work like
    nla_strscpy()
  eth: fbnic: Replace firmware field macros

 drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 109 ++++++++++----------
 drivers/net/ethernet/meta/fbnic/fbnic_fw.h  |   8 +-
 drivers/net/ethernet/meta/fbnic/fbnic_tlv.c |  55 +++++++---
 drivers/net/ethernet/meta/fbnic/fbnic_tlv.h |  39 ++-----
 4 files changed, 110 insertions(+), 101 deletions(-)

--
2.43.5

Re: [PATCH net-next 0/3] eth: fbnic: Cleanup macros and string function

Posted by Jakub Kicinski 11 months, 1 week ago

On Fri, 28 Feb 2025 11:15:25 -0800 Lee Trager wrote:
> We have received some feedback that the macros we use for reading FW mailbox
> attributes are too large in scope and confusing to understanding. Additionally
> the string function did not provide errors allowing it to silently succeed.
> This patch set fixes theses issues.

Applied, thanks!