.../devicetree/bindings/display/msm/gmu.yaml | 1 + arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 8 ++ arch/arm64/boot/dts/qcom/qcs8300.dtsi | 93 ++++++++++++++++++++++ drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 29 +++++++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 13 ++- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++++ drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++ 8 files changed, 171 insertions(+), 3 deletions(-)
This series adds support for A623 GPU found in QCS8300 chipsets. This
GPU IP is very similar to A621 GPU, except for the UBWC configuration
and the GMU firmware.
Both DT patches are for Bjorn and rest of the patches for Rob Clark to
pick up.
---
Changes in v2:
- Fix hwcg config (Konrad)
- Split gpucc reg list patch (Rob)
- Rebase on msm-next tip
- Link to v1: https://lore.kernel.org/r/20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com
---
Jie Zhang (6):
drm/msm/a6xx: Split out gpucc register block
drm/msm/a6xx: Fix gpucc register block for A621
drm/msm/a6xx: Add support for Adreno 623
dt-bindings: display/msm/gmu: Add Adreno 623 GMU
arm64: dts: qcom: qcs8300: Add gpu and gmu nodes
arm64: dts: qcom: qcs8300-ride: Enable Adreno 623 GPU
.../devicetree/bindings/display/msm/gmu.yaml | 1 +
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 8 ++
arch/arm64/boot/dts/qcom/qcs8300.dtsi | 93 ++++++++++++++++++++++
drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 29 +++++++
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 13 ++-
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++++
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++
8 files changed, 171 insertions(+), 3 deletions(-)
---
base-commit: 89839e69f6154feecd79bd01171375225b0296e9
change-id: 20250213-a623-gpu-support-f6698603fb85
prerequisite-change-id: 20250131-b4-branch-gfx-smmu-b03261963064:v5
prerequisite-patch-id: f8fd1a2020c940e595e58a8bd3c55d00d3d87271
prerequisite-patch-id: 08a0540f75b0f95fd2018b38c9ed5c6f96433b4d
Best regards,
--
Akhil P Oommen <quic_akhilpo@quicinc.com>
On Fri, 28 Feb 2025 01:37:48 +0530, Akhil P Oommen wrote: > This series adds support for A623 GPU found in QCS8300 chipsets. This > GPU IP is very similar to A621 GPU, except for the UBWC configuration > and the GMU firmware. > > Both DT patches are for Bjorn and rest of the patches for Rob Clark to > pick up. > > --- > Changes in v2: > - Fix hwcg config (Konrad) > - Split gpucc reg list patch (Rob) > - Rebase on msm-next tip > - Link to v1: https://lore.kernel.org/r/20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com > > --- > Jie Zhang (6): > drm/msm/a6xx: Split out gpucc register block > drm/msm/a6xx: Fix gpucc register block for A621 > drm/msm/a6xx: Add support for Adreno 623 > dt-bindings: display/msm/gmu: Add Adreno 623 GMU > arm64: dts: qcom: qcs8300: Add gpu and gmu nodes > arm64: dts: qcom: qcs8300-ride: Enable Adreno 623 GPU > > .../devicetree/bindings/display/msm/gmu.yaml | 1 + > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 8 ++ > arch/arm64/boot/dts/qcom/qcs8300.dtsi | 93 ++++++++++++++++++++++ > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 29 +++++++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++ > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 13 ++- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++++ > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++ > 8 files changed, 171 insertions(+), 3 deletions(-) > --- > base-commit: 89839e69f6154feecd79bd01171375225b0296e9 > change-id: 20250213-a623-gpu-support-f6698603fb85 > prerequisite-change-id: 20250131-b4-branch-gfx-smmu-b03261963064:v5 > prerequisite-patch-id: f8fd1a2020c940e595e58a8bd3c55d00d3d87271 > prerequisite-patch-id: 08a0540f75b0f95fd2018b38c9ed5c6f96433b4d > > Best regards, > -- > Akhil P Oommen <quic_akhilpo@quicinc.com> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250228-a623-gpu-support-v2-0-aea654ecc1d3@quicinc.com: arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:0: 'gcc_gpu_memnoc_gfx_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:1: 'gcc_gpu_snoc_dvm_gfx_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:2: 'gpu_cc_ahb_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:3: 'gpu_cc_hlos1_vote_gpu_smmu_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:4: 'gpu_cc_cx_gmu_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:5: 'gpu_cc_hub_cx_int_clk' was expected from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml#
On 2/28/2025 7:53 PM, Rob Herring (Arm) wrote: > > On Fri, 28 Feb 2025 01:37:48 +0530, Akhil P Oommen wrote: >> This series adds support for A623 GPU found in QCS8300 chipsets. This >> GPU IP is very similar to A621 GPU, except for the UBWC configuration >> and the GMU firmware. >> >> Both DT patches are for Bjorn and rest of the patches for Rob Clark to >> pick up. >> >> --- >> Changes in v2: >> - Fix hwcg config (Konrad) >> - Split gpucc reg list patch (Rob) >> - Rebase on msm-next tip >> - Link to v1: https://lore.kernel.org/r/20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com >> >> --- >> Jie Zhang (6): >> drm/msm/a6xx: Split out gpucc register block >> drm/msm/a6xx: Fix gpucc register block for A621 >> drm/msm/a6xx: Add support for Adreno 623 >> dt-bindings: display/msm/gmu: Add Adreno 623 GMU >> arm64: dts: qcom: qcs8300: Add gpu and gmu nodes >> arm64: dts: qcom: qcs8300-ride: Enable Adreno 623 GPU >> >> .../devicetree/bindings/display/msm/gmu.yaml | 1 + >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 8 ++ >> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 93 ++++++++++++++++++++++ >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 29 +++++++ >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++ >> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 13 ++- >> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++++ >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++ >> 8 files changed, 171 insertions(+), 3 deletions(-) >> --- >> base-commit: 89839e69f6154feecd79bd01171375225b0296e9 >> change-id: 20250213-a623-gpu-support-f6698603fb85 >> prerequisite-change-id: 20250131-b4-branch-gfx-smmu-b03261963064:v5 >> prerequisite-patch-id: f8fd1a2020c940e595e58a8bd3c55d00d3d87271 >> prerequisite-patch-id: 08a0540f75b0f95fd2018b38c9ed5c6f96433b4d >> >> Best regards, >> -- >> Akhil P Oommen <quic_akhilpo@quicinc.com> >> >> >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250228-a623-gpu-support-v2-0-aea654ecc1d3@quicinc.com: > > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:0: 'gcc_gpu_memnoc_gfx_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:1: 'gcc_gpu_snoc_dvm_gfx_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:2: 'gpu_cc_ahb_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:3: 'gpu_cc_hlos1_vote_gpu_smmu_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:4: 'gpu_cc_cx_gmu_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: iommu@3da0000: clock-names:5: 'gpu_cc_hub_cx_int_clk' was expected > from schema $id: http://devicetree.org/schemas/iommu/arm,smmu.yaml# > > > > > These warnings are for the smmu dt change which I marked as a dependency. Hopefully, the v6 revision from Pratyush will fix this. https://lore.kernel.org/linux-arm-kernel/20250310-b4-branch-gfx-smmu-v6-1-15c60b8abd99@quicinc.com/T/ -Akhil.
On 2/28/2025 1:37 AM, Akhil P Oommen wrote: > This series adds support for A623 GPU found in QCS8300 chipsets. This > GPU IP is very similar to A621 GPU, except for the UBWC configuration > and the GMU firmware. > > Both DT patches are for Bjorn and rest of the patches for Rob Clark to > pick up. > > --- > Changes in v2: > - Fix hwcg config (Konrad) > - Split gpucc reg list patch (Rob) > - Rebase on msm-next tip > - Link to v1: https://lore.kernel.org/r/20250213-a623-gpu-support-v1-0-993c65c39fd2@quicinc.com > > --- > Jie Zhang (6): > drm/msm/a6xx: Split out gpucc register block > drm/msm/a6xx: Fix gpucc register block for A621 > drm/msm/a6xx: Add support for Adreno 623 > dt-bindings: display/msm/gmu: Add Adreno 623 GMU > arm64: dts: qcom: qcs8300: Add gpu and gmu nodes > arm64: dts: qcom: qcs8300-ride: Enable Adreno 623 GPU > > .../devicetree/bindings/display/msm/gmu.yaml | 1 + > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 8 ++ > arch/arm64/boot/dts/qcom/qcs8300.dtsi | 93 ++++++++++++++++++++++ > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 29 +++++++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++ > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 13 ++- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 17 ++++ > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++ > 8 files changed, 171 insertions(+), 3 deletions(-) > --- > base-commit: 89839e69f6154feecd79bd01171375225b0296e9 > change-id: 20250213-a623-gpu-support-f6698603fb85 > prerequisite-change-id: 20250131-b4-branch-gfx-smmu-b03261963064:v5 > prerequisite-patch-id: f8fd1a2020c940e595e58a8bd3c55d00d3d87271 > prerequisite-patch-id: 08a0540f75b0f95fd2018b38c9ed5c6f96433b4d > > Best regards, Bjorn, Now that the adreno smmu changes have merged, can we pick up the GPU DT patches into your tree? https://lore.kernel.org/linux-arm-kernel/174198247897.1604753.3634981110002933426.b4-ty@kernel.org/ -Akhil.
© 2016 - 2025 Red Hat, Inc.