1. Patchew
  2. linux
  3. View series

[PATCH 0/4] Check Rust signatures at compile time

Alice Ryhl posted 4 patches 9 months, 3 weeks ago
There is a newer version of this series
drivers/gpu/drm/drm_panic.c     |  5 -----
drivers/gpu/drm/drm_panic_qr.rs | 15 +++++++++++----
include/drm/drm_panic.h         |  7 +++++++
include/linux/sprintf.h         |  3 +++
lib/vsprintf.c                  |  3 ---
rust/bindings/bindings_helper.h |  4 ++++
rust/kernel/prelude.rs          |  2 +-
rust/kernel/print.rs            | 11 ++++++-----
rust/macros/export.rs           | 25 +++++++++++++++++++++++++
rust/macros/helpers.rs          | 19 ++++++++++++++++++-
rust/macros/lib.rs              | 18 ++++++++++++++++++
rust/macros/quote.rs            | 21 +++++++++++++++++++--
12 files changed, 112 insertions(+), 21 deletions(-)
[PATCH 0/4] Check Rust signatures at compile time
Posted by Alice Ryhl 9 months, 3 weeks ago 
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Alice Ryhl (4):
      rust: fix signature of rust_fmt_argument
      rust: add #[export] macro
      print: use new #[export] macro for rust_fmt_argument
      panic_qr: use new #[export] macro

 drivers/gpu/drm/drm_panic.c     |  5 -----
 drivers/gpu/drm/drm_panic_qr.rs | 15 +++++++++++----
 include/drm/drm_panic.h         |  7 +++++++
 include/linux/sprintf.h         |  3 +++
 lib/vsprintf.c                  |  3 ---
 rust/bindings/bindings_helper.h |  4 ++++
 rust/kernel/prelude.rs          |  2 +-
 rust/kernel/print.rs            | 11 ++++++-----
 rust/macros/export.rs           | 25 +++++++++++++++++++++++++
 rust/macros/helpers.rs          | 19 ++++++++++++++++++-
 rust/macros/lib.rs              | 18 ++++++++++++++++++
 rust/macros/quote.rs            | 21 +++++++++++++++++++--
 12 files changed, 112 insertions(+), 21 deletions(-)
---
base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3
change-id: 20250227-export-macro-9aa9f1016d8c

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Andreas Hindborg 9 months, 3 weeks ago 
"Alice Ryhl" <aliceryhl@google.com> writes:

> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

What is going on with the cover letter of this one?


Best regards,
Andreas Hindborg
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Alice Ryhl 9 months, 3 weeks ago 
On Fri, Feb 28, 2025 at 8:19 AM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
> "Alice Ryhl" <aliceryhl@google.com> writes:
>
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>
> What is going on with the cover letter of this one?

It's empty.

Alice
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Andy Shevchenko 9 months, 3 weeks ago 
On Fri, Feb 28, 2025 at 09:46:32AM +0100, Alice Ryhl wrote:
> On Fri, Feb 28, 2025 at 8:19 AM Andreas Hindborg <a.hindborg@kernel.org> wrote:
> >
> > "Alice Ryhl" <aliceryhl@google.com> writes:
> >
> > > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> >
> > What is going on with the cover letter of this one?
> 
> It's empty.

So, it means nothing to review, sorry.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Andreas Hindborg 9 months, 3 weeks ago 
"Alice Ryhl" <aliceryhl@google.com> writes:

> On Fri, Feb 28, 2025 at 8:19 AM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> "Alice Ryhl" <aliceryhl@google.com> writes:
>>
>> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>>
>> What is going on with the cover letter of this one?
>
> It's empty.

I can see that 😆 Would you consider making it not empty?


Best regards,
Andreas Hindborg
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Greg Kroah-Hartman 9 months, 3 weeks ago 
On Thu, Feb 27, 2025 at 05:01:58PM +0000, Alice Ryhl wrote:
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

It's a bit odd to sign off on a 0/X email with no patch or description
:)

Seriously, nice work!  This resolves the issues I had, and it looks like
you found a needed fix already where things were not quite defined
properly.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Alice Ryhl 9 months, 3 weeks ago 
On Thu, Feb 27, 2025 at 8:31 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 27, 2025 at 05:01:58PM +0000, Alice Ryhl wrote:
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>
> It's a bit odd to sign off on a 0/X email with no patch or description
> :)
>
> Seriously, nice work!  This resolves the issues I had, and it looks like
> you found a needed fix already where things were not quite defined
> properly.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Greg, did you have any input on the choice of header file in the third patch?

Alice
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Alice Ryhl 9 months, 3 weeks ago 
On Thu, Feb 27, 2025 at 8:31 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Feb 27, 2025 at 05:01:58PM +0000, Alice Ryhl wrote:
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
>
> It's a bit odd to sign off on a 0/X email with no patch or description
> :)

What b4 does, I do. ;)

> Seriously, nice work!  This resolves the issues I had, and it looks like
> you found a needed fix already where things were not quite defined
> properly.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks!

Alice
Re: [PATCH 0/4] Check Rust signatures at compile time
Posted by Andy Shevchenko 9 months, 3 weeks ago 
On Thu, Feb 27, 2025 at 05:01:58PM +0000, Alice Ryhl wrote:

This is unfortunate. What does this mean?
Can you, please, provide a meaningful cover letter?

> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.