[PATCH v3 00/20] ASoC: tas27{64,70}: improve support for Apple codec variants

James Calligeros posted 20 patches 9 months, 2 weeks ago
There is a newer version of this series
.../bindings/sound/ti,tas2770.yaml       |  13 ++
.../bindings/sound/ti,tas27xx.yaml       |   5 +
sound/soc/codecs/tas2764-quirks.h        | 180 +++++++++++++++++
sound/soc/codecs/tas2764.c               | 258 ++++++++++++++++++++++++-
sound/soc/codecs/tas2764.h               |  21 ++
sound/soc/codecs/tas2770.c               | 240 ++++++++++++++++++++---
sound/soc/codecs/tas2770.h               |  19 ++
7 files changed, 706 insertions(+), 30 deletions(-)
[PATCH v3 00/20] ASoC: tas27{64,70}: improve support for Apple codec variants
Posted by James Calligeros 9 months, 2 weeks ago
Hi all,

This series introduces a number of changes to the drivers for
the Texas Instruments TAS2764 and TAS2770 amplifiers in order to
introduce (and improve in the case of TAS2770) support for the
variants of these amps found in Apple Silicon Macs.

Apple's variant of TAS2764 is known as SN012776, and as always with
Apple is a subtly incompatible variant with a number of quirks. It
is not publicly available. The TAS2770 variant is known as TAS5770L,
and does not require incompatible handling.

Much as with the Cirrus codec patches, I do not
expect that we will get any official acknowledgement that these parts
exist from TI, however I would be delighted to be proven wrong.

This series has been living in the downstream Asahi kernel tree[1]
for over two years, and has been tested by many thousands of users
by this point[2].

[1] https://github.com/AsahiLinux/linux/tree/asahi-wip
[2] https://stats.asahilinux.org/

---
Changes in v3:
- Add Rob's Acked-by to Devicetree compatible additions
- Dropped cherry-picked patches
- Droped abuse of regulator API
- Droped bespoke sysfs interface
- Rationalised temperature reading for hwmon interface
- Set SN012776 device ID with OF match data
- Changed probe ops reliant on device ID to case/switch statement
- Added documentation for new Devicetree properties
- Improved a number of poor quality commit messages
- Documented behaviour of die temperature ADC
- Link to v2: https://lore.kernel.org/r/20250218-apple-codec-changes-v2-0-932760fd7e07@gmail.com

Changes in v2:
- Changed author field of patch to match Martin's Signed-off-by
- Added Neal's Reviewed-by to reviewed patches
- Moved fixes to existing code to the top of the series
- Removed tas2764's explicit dependency on OF
- Removed complicated single-use tas2764 quirks macro and replaced with
  if block
- Added hwmon interface for codec die temp
- Fixed a malformed commit message
- Link to v1: https://lore.kernel.org/r/20250215-apple-codec-changes-v1-0-723569b21b19@gmail.com

---
Hector Martin (5):
      ASoC: tas2764: Enable main IRQs
      ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
      ASoC: tas2770: Add zero-fill and pull-down controls
      ASoC: tas2770: Support setting the PDM TX slot
      ASoC: tas2770: Set the SDOUT polarity correctly

James Calligeros (6):
      ASoC: dt-bindings: tas27xx: add compatible for SN012776
      ASoC: dt-bindings: tas2770: add compatible for TAS5770L
      ASoC: dt-bindings: tas27xx: document ti,sdout-force-zero-mask property
      ASoC: tas2770: expose die temp to hwmon
      ASoC: tas2764: expose die temp to hwmon
      ASoC: dt-bindings: tas2770: add flags for SDOUT pulldown and zero-fill

Martin Povišer (9):
      ASoC: tas2764: Extend driver to SN012776
      ASoC: tas2764: Add control concerning overcurrent events
      ASoC: tas2770: Factor out set_ivsense_slots
      ASoC: tas2770: Fix and redo I/V sense TDM slot setting logic
      ASoC: tas2764: Reinit cache on part reset
      ASoC: tas2764: Configure zeroing of SDOUT slots
      ASoC: tas2764: Apply Apple quirks
      ASoC: tas2764: Raise regmap range maximum
      ASoC: tas2764: Crop SDOUT zero-out mask based on BCLK ratio

 .../bindings/sound/ti,tas2770.yaml       |  13 ++
 .../bindings/sound/ti,tas27xx.yaml       |   5 +
 sound/soc/codecs/tas2764-quirks.h        | 180 +++++++++++++++++
 sound/soc/codecs/tas2764.c               | 258 ++++++++++++++++++++++++-
 sound/soc/codecs/tas2764.h               |  21 ++
 sound/soc/codecs/tas2770.c               | 240 ++++++++++++++++++++---
 sound/soc/codecs/tas2770.h               |  19 ++
 7 files changed, 706 insertions(+), 30 deletions(-)
---
base-commit: 32adeb9806ac5bf928514b62e6145bba12dfd71a
change-id: 20250214-apple-codec-changes-6e656dc1e24d

Best regards,
-- 
James Calligeros <jcalligeros99@gmail.com>

Re: (subset) [PATCH v3 00/20] ASoC: tas27{64,70}: improve support for Apple codec variants
Posted by Mark Brown 8 months ago
On Thu, 27 Feb 2025 22:07:27 +1000, James Calligeros wrote:
> This series introduces a number of changes to the drivers for
> the Texas Instruments TAS2764 and TAS2770 amplifiers in order to
> introduce (and improve in the case of TAS2770) support for the
> variants of these amps found in Apple Silicon Macs.
> 
> Apple's variant of TAS2764 is known as SN012776, and as always with
> Apple is a subtly incompatible variant with a number of quirks. It
> is not publicly available. The TAS2770 variant is known as TAS5770L,
> and does not require incompatible handling.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[07/20] ASoC: tas2764: Reinit cache on part reset
        commit: 592ab3936b096da5deb64d4c906edbeb989174d6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: (subset) [PATCH v3 00/20] ASoC: tas27{64,70}: improve support for Apple codec variants
Posted by Mark Brown 9 months ago
On Thu, 27 Feb 2025 22:07:27 +1000, James Calligeros wrote:
> This series introduces a number of changes to the drivers for
> the Texas Instruments TAS2764 and TAS2770 amplifiers in order to
> introduce (and improve in the case of TAS2770) support for the
> variants of these amps found in Apple Silicon Macs.
> 
> Apple's variant of TAS2764 is known as SN012776, and as always with
> Apple is a subtly incompatible variant with a number of quirks. It
> is not publicly available. The TAS2770 variant is known as TAS5770L,
> and does not require incompatible handling.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/20] ASoC: dt-bindings: tas27xx: add compatible for SN012776
        commit: 25a83f870b8a25a4b10bf5ba474a017ed5a72e7d
[02/20] ASoC: dt-bindings: tas2770: add compatible for TAS5770L
        commit: ce9233937f3233e277ff23395e61ea690c769bef
[03/20] ASoC: tas2764: Extend driver to SN012776
        commit: ad18392962df46a858432839cc6bcaf2ede7cc86
[04/20] ASoC: tas2764: Add control concerning overcurrent events
        commit: f8d5f28e3f2ece5a1392205022afe30c87107a9b
[05/20] ASoC: tas2770: Factor out set_ivsense_slots
        commit: 6553ee024b4452ef861de10605156c9d79e208ab
[06/20] ASoC: tas2770: Fix and redo I/V sense TDM slot setting logic
        commit: f0066c8d1d3298e9f9d136a365139bac733e84c5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark