[v1] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages

[PATCH] [fix] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages

Posted by Sun YangKai 9 months, 3 weeks ago

This is currently the only atomic_long_t variable initialized by
ATOMIC_INIT macro found in the kernel by using
`grep -r atomic_long_t | grep ATOMIC_INIT`

Signed-off-by: Sun YangKai <sunk67188@gmail.com>
---
 mm/zswap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index ac9d299e7d0c..23365e76a3ce 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -43,7 +43,7 @@
 * statistics
 **********************************/
 /* The number of compressed pages currently stored in zswap */
-atomic_long_t zswap_stored_pages = ATOMIC_INIT(0);
+atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);
 
 /*
  * The statistics below are not protected from concurrent access for
-- 
2.48.1

Re: [PATCH] [fix] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages

Posted by Nhat Pham 9 months, 3 weeks ago

On Wed, Feb 26, 2025 at 12:04 AM Sun YangKai <sunk67188@gmail.com> wrote:
>
> This is currently the only atomic_long_t variable initialized by
> ATOMIC_INIT macro found in the kernel by using
> `grep -r atomic_long_t | grep ATOMIC_INIT`
>

nit: patch description seems non-descriptive. Perhaps you can add some
context - when was this issue first introduced into our codebase?

Also, I think you'll need a fix tag:

Fixes: 6e1fa55 ("mm: zswap: modify zswap_stored_pages to be atomic_long_t")

since the atomic_long_t type was introduced by that patch.
> Signed-off-by: Sun YangKai <sunk67188@gmail.com>
> ---
>  mm/zswap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index ac9d299e7d0c..23365e76a3ce 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -43,7 +43,7 @@
>  * statistics
>  **********************************/
>  /* The number of compressed pages currently stored in zswap */
> -atomic_long_t zswap_stored_pages = ATOMIC_INIT(0);
> +atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);

Code itself LGTM FWIW :)