drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

[PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

Posted by Rob Clark 9 months, 3 weeks ago

From: Rob Clark <robdclark@chromium.org>

Initially we didn't want to expose the cap, as it would expose a bug
in the vk driver (turnip) with older mesa versions.  This was fixed over
a year ago (and cherry-picked to stable release branches at the time),
see https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981.
So let's go ahead and expose it now.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/msm/msm_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 37db92c8cecb..70373e0fd4a6 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -812,6 +812,7 @@ static const struct drm_driver msm_driver = {
 				DRIVER_RENDER |
 				DRIVER_ATOMIC |
 				DRIVER_MODESET |
+				DRIVER_SYNCOBJ_TIMELINE |
 				DRIVER_SYNCOBJ,
 	.open               = msm_open,
 	.postclose          = msm_postclose,
-- 
2.48.1

Re: [PATCH] drm/msm: Expose DRIVER_SYNCOBJ_TIMELINE

Posted by Akhil P Oommen 9 months, 3 weeks ago

On 2/26/2025 4:22 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Initially we didn't want to expose the cap, as it would expose a bug
> in the vk driver (turnip) with older mesa versions.  This was fixed over
> a year ago (and cherry-picked to stable release branches at the time),
> see https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25981.
> So let's go ahead and expose it now.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>

-Akhil

> ---
>  drivers/gpu/drm/msm/msm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 37db92c8cecb..70373e0fd4a6 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -812,6 +812,7 @@ static const struct drm_driver msm_driver = {
>  				DRIVER_RENDER |
>  				DRIVER_ATOMIC |
>  				DRIVER_MODESET |
> +				DRIVER_SYNCOBJ_TIMELINE |
>  				DRIVER_SYNCOBJ,
>  	.open               = msm_open,
>  	.postclose          = msm_postclose,