tools/arch/x86/include/linux doesn't exist but building is working by
virtue of a -I. Building using bazel this fails. Use angle brackets to
include unaligned.h so there isn't an invalid relative include.

Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/arch/x86/lib/insn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
index ab5cdc3337da..e91d4c4e1c16 100644
--- a/tools/arch/x86/lib/insn.c
+++ b/tools/arch/x86/lib/insn.c
@@ -13,7 +13,7 @@
 #endif
 #include "../include/asm/inat.h" /* __ignore_sync_check__ */
 #include "../include/asm/insn.h" /* __ignore_sync_check__ */
-#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
+#include <linux/unaligned.h> /* __ignore_sync_check__ */
 
 #include <linux/errno.h>
 #include <linux/kconfig.h>
-- 
2.48.1.711.g2feabab25a-goog

On Tue, 25 Feb 2025 11:36:00 -0800, Ian Rogers wrote:
> tools/arch/x86/include/linux doesn't exist but building is working by
> virtue of a -I. Building using bazel this fails. Use angle brackets to
> include unaligned.h so there isn't an invalid relative include.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> tools/arch/x86/include/linux doesn't exist but building is working by
> virtue of a -I. Building using bazel this fails. Use angle brackets to
> include unaligned.h so there isn't an invalid relative include.

Right, it's using tools/include/linux/unaligned.h.

Thanks,
Namhyung

> 
> Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/arch/x86/lib/insn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> index ab5cdc3337da..e91d4c4e1c16 100644
> --- a/tools/arch/x86/lib/insn.c
> +++ b/tools/arch/x86/lib/insn.c
> @@ -13,7 +13,7 @@
>  #endif
>  #include "../include/asm/inat.h" /* __ignore_sync_check__ */
>  #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> +#include <linux/unaligned.h> /* __ignore_sync_check__ */
>  
>  #include <linux/errno.h>
>  #include <linux/kconfig.h>
> -- 
> 2.48.1.711.g2feabab25a-goog
>

Adding Josh and Peter as it's used in objtool as well.

On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > tools/arch/x86/include/linux doesn't exist but building is working by
> > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > include unaligned.h so there isn't an invalid relative include.
> 
> Right, it's using tools/include/linux/unaligned.h.

Josh, are you ok with this?  I can carry this in the perf tools tree if
you don't mind.

Thanks,
Namhyung

> 
> > 
> > Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/arch/x86/lib/insn.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> > index ab5cdc3337da..e91d4c4e1c16 100644
> > --- a/tools/arch/x86/lib/insn.c
> > +++ b/tools/arch/x86/lib/insn.c
> > @@ -13,7 +13,7 @@
> >  #endif
> >  #include "../include/asm/inat.h" /* __ignore_sync_check__ */
> >  #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> > -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> > +#include <linux/unaligned.h> /* __ignore_sync_check__ */
> >  
> >  #include <linux/errno.h>
> >  #include <linux/kconfig.h>
> > -- 
> > 2.48.1.711.g2feabab25a-goog
> >

On Thu, Feb 27, 2025 at 08:46:26AM -0800, Namhyung Kim wrote:
> Adding Josh and Peter as it's used in objtool as well.
> 
> On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> > On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > > tools/arch/x86/include/linux doesn't exist but building is working by
> > > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > > include unaligned.h so there isn't an invalid relative include.
> > 
> > Right, it's using tools/include/linux/unaligned.h.
> 
> Josh, are you ok with this?  I can carry this in the perf tools tree if
> you don't mind.

LGTM

Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>

-- 
Josh