scsi: hisi: remove incorrect ACPI_PTR annotations

[PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Arnd Bergmann 11 months, 2 weeks ago

From: Arnd Bergmann <arnd@arndb.de>

Building with W=1 shows a warning about sas_v2_acpi_match being unused when
CONFIG_OF is disabled:

    drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 +-
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index bb78e53c66e2..6621d633b2cc 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1806,7 +1806,7 @@ static struct platform_driver hisi_sas_v1_driver = {
 	.driver = {
 		.name = DRV_NAME,
 		.of_match_table = sas_v1_of_match,
-		.acpi_match_table = ACPI_PTR(sas_v1_acpi_match),
+		.acpi_match_table = sas_v1_acpi_match,
 	},
 };
 
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index 71cd5b4450c2..3cc4cddcb655 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -3653,7 +3653,7 @@ static struct platform_driver hisi_sas_v2_driver = {
 	.driver = {
 		.name = DRV_NAME,
 		.of_match_table = sas_v2_of_match,
-		.acpi_match_table = ACPI_PTR(sas_v2_acpi_match),
+		.acpi_match_table = sas_v2_acpi_match,
 	},
 };
 
-- 
2.39.5

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Martin K. Petersen 11 months ago

On Tue, 25 Feb 2025 17:36:27 +0100, Arnd Bergmann wrote:

> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
> CONFIG_OF is disabled:
> 
>     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
> 
> 

Applied to 6.15/scsi-queue, thanks!

[1/1] scsi: hisi: remove incorrect ACPI_PTR annotations
      https://git.kernel.org/mkp/scsi/c/7a9c0476d407

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Martin K. Petersen 11 months, 1 week ago

Arnd,

> Building with W=1 shows a warning about sas_v2_acpi_match being unused
> when CONFIG_OF is disabled:

Applied to 6.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Yihang Li 11 months, 2 weeks ago

On 2025/2/26 0:36, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
> CONFIG_OF is disabled:
> 
>     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good. So Reviewed-by: Yihang Li <liyihang9@huawei.com>

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Uwe Kleine-König 11 months, 1 week ago

Hello,

On Wed, Feb 26, 2025 at 11:23:18AM +0800, Yihang Li wrote:
> On 2025/2/26 0:36, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Building with W=1 shows a warning about sas_v2_acpi_match being unused when
> > CONFIG_OF is disabled:
> > 
> >     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks good. So Reviewed-by: Yihang Li <liyihang9@huawei.com>

If you put your Reviewed-by tag in a separate line, the tooling that
most maintainers use pick it up automatically. Martin applied your patch
(currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging
) indeed without your tag.

Best regards
Uwe

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Yihang Li 11 months, 1 week ago


On 2025/3/4 13:12, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 26, 2025 at 11:23:18AM +0800, Yihang Li wrote:
>> On 2025/2/26 0:36, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
>>> CONFIG_OF is disabled:
>>>
>>>     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good. So Reviewed-by: Yihang Li <liyihang9@huawei.com>
> 
> If you put your Reviewed-by tag in a separate line, the tooling that
> most maintainers use pick it up automatically. Martin applied your patch
> (currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging
> ) indeed without your tag.
> 

Ok, thanks for the reminder. I'll pay attention next time.

Thanks
Yihang

Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

Posted by Damien Le Moal 11 months, 2 weeks ago

On 2/26/25 1:36 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
> CONFIG_OF is disabled:
> 
>     drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research