rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

[PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

Posted by Arnd Bergmann 11 months, 2 weeks ago

From: Arnd Bergmann <arnd@arndb.de>

Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
CONFIG_ACPI is disabled:

drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index a72c4ad0cec6..12da7d36e520 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -320,7 +320,7 @@ static struct platform_driver ftm_rtc_driver = {
 	.driver		= {
 		.name	= "ftm-alarm",
 		.of_match_table = ftm_rtc_match,
-		.acpi_match_table = ACPI_PTR(ftm_imx_acpi_ids),
+		.acpi_match_table = ftm_imx_acpi_ids,
 	},
 };
 
-- 
2.39.5

Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

Posted by Krzysztof Kozlowski 11 months, 2 weeks ago

On 25/02/2025 17:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
> CONFIG_ACPI is disabled:
> 
> drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I already sent a fix for this few days ago:

https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

Posted by Alexandre Belloni 11 months, 2 weeks ago

On 25/02/2025 18:12:10+0100, Krzysztof Kozlowski wrote:
> On 25/02/2025 17:34, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
> > CONFIG_ACPI is disabled:
> > 
> > drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I already sent a fix for this few days ago:
> 
> https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@linaro.org/
> 

But wouldn't Arnd's one be better?

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation

Posted by Krzysztof Kozlowski 11 months, 2 weeks ago

On 25/02/2025 18:16, Alexandre Belloni wrote:
> On 25/02/2025 18:12:10+0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 17:34, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
>>> CONFIG_ACPI is disabled:
>>>
>>> drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I already sent a fix for this few days ago:
>>
>> https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@linaro.org/
>>
> 
> But wouldn't Arnd's one be better?

ACPI table can be here entirely dropped and driver will match via
PRP0001, so I think ACPI_PTR makes sense.

But if you have arguments for keeping both, sure... There was no
response to my trivial patch and multiple people will be wasting same
time on the same issue. So just apply whichever of these, before third
person wastes more time on that warning.

Best regards,
Krzysztof