[PATCH v1 1/9] ARM: tegra: Add ACTMON support on Tegra114

Svyatoslav Ryhel posted 9 patches 11 months, 2 weeks ago
There is a newer version of this series
[PATCH v1 1/9] ARM: tegra: Add ACTMON support on Tegra114
Posted by Svyatoslav Ryhel 11 months, 2 weeks ago
Add support for ACTMON on Tegra114. This is used to monitor activity from
different components. Based on the collected statistics, the rate at which
the external memory needs to be clocked can be derived.

Actmon driver has T30 and T124 compatibles, T124 fits for T114 as well.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 arch/arm/boot/dts/nvidia/tegra114.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/nvidia/tegra114.dtsi b/arch/arm/boot/dts/nvidia/tegra114.dtsi
index 86f14e2fd29f..a309999e7988 100644
--- a/arch/arm/boot/dts/nvidia/tegra114.dtsi
+++ b/arch/arm/boot/dts/nvidia/tegra114.dtsi
@@ -246,6 +246,17 @@ ahb: ahb@6000c000 {
 		reg = <0x6000c000 0x150>;
 	};
 
+	actmon: actmon@6000c800 {
+		compatible = "nvidia,tegra114-actmon", "nvidia,tegra124-actmon";
+		reg = <0x6000c800 0x400>;
+		interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&tegra_car TEGRA114_CLK_ACTMON>,
+			 <&tegra_car TEGRA114_CLK_EMC>;
+		clock-names = "actmon", "emc";
+		resets = <&tegra_car TEGRA114_CLK_ACTMON>;
+		reset-names = "actmon";
+	};
+
 	gpio: gpio@6000d000 {
 		compatible = "nvidia,tegra114-gpio", "nvidia,tegra30-gpio";
 		reg = <0x6000d000 0x1000>;
-- 
2.43.0
Re: [PATCH v1 1/9] ARM: tegra: Add ACTMON support on Tegra114
Posted by Krzysztof Kozlowski 11 months, 2 weeks ago
On 25/02/2025 15:34, Svyatoslav Ryhel wrote:
> Add support for ACTMON on Tegra114. This is used to monitor activity from
> different components. Based on the collected statistics, the rate at which
> the external memory needs to be clocked can be derived.
> 
> Actmon driver has T30 and T124 compatibles, T124 fits for T114 as well.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---

DTS at beginning of patchset suggests you have dependency and nothing
can depend on DTS. Please organize it for standard way, so DTS is at the
end or, *better* separate patchset.

Nothing in cover letter explained dependecies, so I assume this can be
split into separate patchsets, because you target two different subsystems.

Best regards,
Krzysztof