[PATCH v1 0/9] Tegra114: implement EMC support

Svyatoslav Ryhel posted 9 patches 11 months, 2 weeks ago
There is a newer version of this series
.../nvidia,tegra114-emc.yaml                  |  431 +++++
.../nvidia,tegra114-mc.yaml                   |  154 ++
.../dts/nvidia/tegra114-peripherals-opp.dtsi  |  151 ++
arch/arm/boot/dts/nvidia/tegra114.dtsi        |   32 +
drivers/clk/tegra/clk-tegra114.c              |   48 +-
drivers/memory/tegra/Kconfig                  |   12 +
drivers/memory/tegra/Makefile                 |    1 +
drivers/memory/tegra/tegra114-emc.c           | 1487 +++++++++++++++++
drivers/memory/tegra/tegra114.c               |  193 +++
include/dt-bindings/memory/tegra114-mc.h      |   67 +
10 files changed, 2561 insertions(+), 15 deletions(-)
create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-mc.yaml
create mode 100644 arch/arm/boot/dts/nvidia/tegra114-peripherals-opp.dtsi
create mode 100644 drivers/memory/tegra/tegra114-emc.c
[PATCH v1 0/9] Tegra114: implement EMC support
Posted by Svyatoslav Ryhel 11 months, 2 weeks ago
Add support for External Memory Controller found in Tegra 4 SoC along
with adjustments required for it to work properly.

Tested on ASUS TF701T (T40X) and Nvidia Tegratab (T40S). Both work fine.

Svyatoslav Ryhel (9):
  ARM: tegra: Add ACTMON support on Tegra114
  dt-bindings: memory: Document Tegra114 Memory Controller
  drivers: memory: tegra: implement EMEM regs and ICC ops for T114
  dt-bindings: memory: tegra114: Add memory client IDs
  clk: tegra114: remove emc to mc clock mux
  dt-bindings: memory: Document Tegra114 External Memory Controller
  memory: tegra: Add Tegra114 EMC driver
  ARM: tegra: Add External Memory Controller node on Tegra114
  ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON
    device-tree nodes

 .../nvidia,tegra114-emc.yaml                  |  431 +++++
 .../nvidia,tegra114-mc.yaml                   |  154 ++
 .../dts/nvidia/tegra114-peripherals-opp.dtsi  |  151 ++
 arch/arm/boot/dts/nvidia/tegra114.dtsi        |   32 +
 drivers/clk/tegra/clk-tegra114.c              |   48 +-
 drivers/memory/tegra/Kconfig                  |   12 +
 drivers/memory/tegra/Makefile                 |    1 +
 drivers/memory/tegra/tegra114-emc.c           | 1487 +++++++++++++++++
 drivers/memory/tegra/tegra114.c               |  193 +++
 include/dt-bindings/memory/tegra114-mc.h      |   67 +
 10 files changed, 2561 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-mc.yaml
 create mode 100644 arch/arm/boot/dts/nvidia/tegra114-peripherals-opp.dtsi
 create mode 100644 drivers/memory/tegra/tegra114-emc.c

-- 
2.43.0
Re: [PATCH v1 0/9] Tegra114: implement EMC support
Posted by Svyatoslav Ryhel 10 months ago
вт, 25 лют. 2025 р. о 16:35 Svyatoslav Ryhel <clamor95@gmail.com> пише:
>
> Add support for External Memory Controller found in Tegra 4 SoC along
> with adjustments required for it to work properly.
>
> Tested on ASUS TF701T (T40X) and Nvidia Tegratab (T40S). Both work fine.
>
> Svyatoslav Ryhel (9):
>   ARM: tegra: Add ACTMON support on Tegra114
>   dt-bindings: memory: Document Tegra114 Memory Controller
>   drivers: memory: tegra: implement EMEM regs and ICC ops for T114
>   dt-bindings: memory: tegra114: Add memory client IDs
>   clk: tegra114: remove emc to mc clock mux
>   dt-bindings: memory: Document Tegra114 External Memory Controller
>   memory: tegra: Add Tegra114 EMC driver
>   ARM: tegra: Add External Memory Controller node on Tegra114
>   ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON
>     device-tree nodes
>
>  .../nvidia,tegra114-emc.yaml                  |  431 +++++
>  .../nvidia,tegra114-mc.yaml                   |  154 ++
>  .../dts/nvidia/tegra114-peripherals-opp.dtsi  |  151 ++
>  arch/arm/boot/dts/nvidia/tegra114.dtsi        |   32 +
>  drivers/clk/tegra/clk-tegra114.c              |   48 +-
>  drivers/memory/tegra/Kconfig                  |   12 +
>  drivers/memory/tegra/Makefile                 |    1 +
>  drivers/memory/tegra/tegra114-emc.c           | 1487 +++++++++++++++++
>  drivers/memory/tegra/tegra114.c               |  193 +++
>  include/dt-bindings/memory/tegra114-mc.h      |   67 +
>  10 files changed, 2561 insertions(+), 15 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-mc.yaml
>  create mode 100644 arch/arm/boot/dts/nvidia/tegra114-peripherals-opp.dtsi
>  create mode 100644 drivers/memory/tegra/tegra114-emc.c
>
> --
> 2.43.0
>

These patches had no activity/feedback from tegra maintainers for a
while, so, in case they got lost in the depths of email box, this is a
friendly reminder that they are still relevant and I would like them
to move on.

Best regards,
Svyatoslav R.
Re: [PATCH v1 0/9] Tegra114: implement EMC support
Posted by Krzysztof Kozlowski 10 months ago
On 08/04/2025 07:43, Svyatoslav Ryhel wrote:
>>
> 
> These patches had no activity/feedback from tegra maintainers for a
> while, so, in case they got lost in the depths of email box, this is a
> friendly reminder that they are still relevant and I would like them
> to move on.
Huh? So you just ignore the review?

I am not going to consider picking these up if you are not going to
implement the review. What's more, your waiting 1.5 months after the
review to ping is just inappropriate.

Best regards,
Krzysztof
Re: [PATCH v1 0/9] Tegra114: implement EMC support
Posted by Svyatoslav Ryhel 10 months ago
вт, 8 квіт. 2025 р. о 08:47 Krzysztof Kozlowski <krzk@kernel.org> пише:
>
> On 08/04/2025 07:43, Svyatoslav Ryhel wrote:
> >>
> >
> > These patches had no activity/feedback from tegra maintainers for a
> > while, so, in case they got lost in the depths of email box, this is a
> > friendly reminder that they are still relevant and I would like them
> > to move on.
> Huh? So you just ignore the review?
>
> I am not going to consider picking these up if you are not going to
> implement the review. What's more, your waiting 1.5 months after the
> review to ping is just inappropriate.
>

Don't get me wrong, I would like to hear feedback from Tegra
maintainers and I have specified that in my message. Don't be so mean.

> Best regards,
> Krzysztof
Re: [PATCH v1 0/9] Tegra114: implement EMC support
Posted by Rob Herring (Arm) 11 months, 2 weeks ago
On Tue, 25 Feb 2025 16:34:52 +0200, Svyatoslav Ryhel wrote:
> Add support for External Memory Controller found in Tegra 4 SoC along
> with adjustments required for it to work properly.
> 
> Tested on ASUS TF701T (T40X) and Nvidia Tegratab (T40S). Both work fine.
> 
> Svyatoslav Ryhel (9):
>   ARM: tegra: Add ACTMON support on Tegra114
>   dt-bindings: memory: Document Tegra114 Memory Controller
>   drivers: memory: tegra: implement EMEM regs and ICC ops for T114
>   dt-bindings: memory: tegra114: Add memory client IDs
>   clk: tegra114: remove emc to mc clock mux
>   dt-bindings: memory: Document Tegra114 External Memory Controller
>   memory: tegra: Add Tegra114 EMC driver
>   ARM: tegra: Add External Memory Controller node on Tegra114
>   ARM: tegra: Add EMC OPP and ICC properties to Tegra114 EMC and ACTMON
>     device-tree nodes
> 
>  .../nvidia,tegra114-emc.yaml                  |  431 +++++
>  .../nvidia,tegra114-mc.yaml                   |  154 ++
>  .../dts/nvidia/tegra114-peripherals-opp.dtsi  |  151 ++
>  arch/arm/boot/dts/nvidia/tegra114.dtsi        |   32 +
>  drivers/clk/tegra/clk-tegra114.c              |   48 +-
>  drivers/memory/tegra/Kconfig                  |   12 +
>  drivers/memory/tegra/Makefile                 |    1 +
>  drivers/memory/tegra/tegra114-emc.c           | 1487 +++++++++++++++++
>  drivers/memory/tegra/tegra114.c               |  193 +++
>  include/dt-bindings/memory/tegra114-mc.h      |   67 +
>  10 files changed, 2561 insertions(+), 15 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-mc.yaml
>  create mode 100644 arch/arm/boot/dts/nvidia/tegra114-peripherals-opp.dtsi
>  create mode 100644 drivers/memory/tegra/tegra114-emc.c
> 
> --
> 2.43.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/nvidia/' for 20250225143501.68966-1-clamor95@gmail.com:

arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: clock@60006000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: actmon@6000c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-tn7.dtb: actmon@6000c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: clock@60006000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: actmon@6000c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-roth.dtb: actmon@6000c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: clock@60006000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: actmon@6000c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-dalmore.dtb: actmon@6000c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: clock@60006000: 'nvidia,external-memory-controller' does not match any of the regexes: '^(sclk)|(pll-[cem])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/nvidia,tegra20-car.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: actmon@6000c800: compatible: ['nvidia,tegra114-actmon', 'nvidia,tegra124-actmon'] is too long
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: actmon@6000c800: '#cooling-cells' is a required property
	from schema $id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml#
arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dtb: bluetooth: reset-gpios: False schema does not allow [[22, 134, 1]]
	from schema $id: http://devicetree.org/schemas/net/bluetooth/brcm,bluetooth.yaml#