[PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi

niravkumar.l.rabara@intel.com posted 1 patch 11 months, 2 weeks ago
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
1 file changed, 4 insertions(+)
[PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
Posted by niravkumar.l.rabara@intel.com 11 months, 2 weeks ago
From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Add DMA channel ids for spi0 and spi1 nodes in device tree.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 1235ba5a9865..616259447c6f 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -457,6 +457,8 @@ spi0: spi@ffda4000 {
 			reg-io-width = <4>;
 			num-cs = <4>;
 			clocks = <&clkmgr AGILEX_L4_MAIN_CLK>;
+			dmas = <&pdma 16>, <&pdma 17>;
+			dma-names = "tx", "rx";
 			status = "disabled";
 		};
 
@@ -471,6 +473,8 @@ spi1: spi@ffda5000 {
 			reg-io-width = <4>;
 			num-cs = <4>;
 			clocks = <&clkmgr AGILEX_L4_MAIN_CLK>;
+			dmas = <&pdma 20>, <&pdma 21>;
+			dma-names = "tx", "rx";
 			status = "disabled";
 		};
 
-- 
2.25.1
Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
Posted by Dinh Nguyen 11 months, 1 week ago
On 2/25/25 07:39, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> Add DMA channel ids for spi0 and spi1 nodes in device tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
>   arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index 1235ba5a9865..616259447c6f 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -457,6 +457,8 @@ spi0: spi@ffda4000 {

Applied!

Thanks,
Dinh
Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
Posted by Krzysztof Kozlowski 11 months, 2 weeks ago
On 25/02/2025 14:39, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> Add DMA channel ids for spi0 and spi1 nodes in device tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

That's not a bugfix.

Why do you Cc stable?

Best regards,
Krzysztof
RE: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel id for spi
Posted by Rabara, Niravkumar L 11 months, 2 weeks ago
Hi Krysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Wednesday, 26 February, 2025 2:02 AM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@intel.com>; Dinh Nguyen
> <dinguyen@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> nirav.rabara@altera.com; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: stable@vger.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>
> Subject: Re: [PATCH RESEND v2] arm64: dts: socfpga: agilex: Add dma channel
> id for spi
> 
> On 25/02/2025 14:39, niravkumar.l.rabara@intel.com wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> >
> > Add DMA channel ids for spi0 and spi1 nodes in device tree.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> That's not a bugfix.
> 
> Why do you Cc stable?
> 
It was a mistake. Do I need to resend this patch without Cc Stable? 

Thanks,
Nirav