media: i2c: Replace nested min() with single min3()

[PATCH] media: i2c: Replace nested min() with single min3()

Posted by Qasim Ijaz 11 months, 2 weeks ago

Use min3() macro instead of nesting min() to simplify the return
statement.

Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
 drivers/media/i2c/vgxy61.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
index d77468c8587b..5b0479f3a3c0 100644
--- a/drivers/media/i2c/vgxy61.c
+++ b/drivers/media/i2c/vgxy61.c
@@ -892,8 +892,8 @@ static u32 vgxy61_get_expo_long_max(struct vgxy61_dev *sensor,
 	third_rot_max_expo = (sensor->frame_length / 71) * short_expo_ratio;
 
 	/* Take the minimum from all rules */
-	return min(min(first_rot_max_expo, second_rot_max_expo),
-		   third_rot_max_expo);
+	return min3(first_rot_max_expo, second_rot_max_expo,
+		    third_rot_max_expo);
 }
 
 static int vgxy61_update_exposure(struct vgxy61_dev *sensor, u16 new_expo_long,
-- 
2.39.5

Re: [PATCH] media: i2c: Replace nested min() with single min3()

Posted by Sakari Ailus 11 months, 2 weeks ago

Hi Qasim,

On Tue, Feb 25, 2025 at 12:59:37PM +0000, Qasim Ijaz wrote:
> Use min3() macro instead of nesting min() to simplify the return
> statement.

Going forward, for this driver on subject:

s/i2c/vgxy61/

as this is a driver for vgxy61. I've done that this time.

-- 
Regards,

Sakari Ailus

Re: [PATCH] media: i2c: Replace nested min() with single min3()

Posted by Markus Elfring 11 months, 2 weeks ago

…
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -892,8 +892,8 @@ static u32 vgxy61_get_expo_long_max(struct vgxy61_dev *sensor,
>  	third_rot_max_expo = (sensor->frame_length / 71) * short_expo_ratio;
>
>  	/* Take the minimum from all rules */
> -	return min(min(first_rot_max_expo, second_rot_max_expo),
> -		   third_rot_max_expo);
> +	return min3(first_rot_max_expo, second_rot_max_expo,
> +		    third_rot_max_expo);
…

Can the following source code variant be applied?

+	return min3(first_rot_max_expo, second_rot_max_expo, third_rot_max_expo);


Regards,
Markus