[v2] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

[PATCH v2] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

Posted by Harshal Chaudhari 9 months, 3 weeks ago

Non IP flow, with vlan tag not working as expected while
running below command for vlan-priority. fixed that.

ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0

Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.")
Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com>
---

Notes:
    Change from v1:
            - Added the fixes tag
    Change from v2:
            - Corrected description format.

 drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 1641791a2d5b..8ed83fb98862 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -324,7 +324,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = {
 		       MVPP2_PRS_RI_VLAN_MASK),
 	/* Non IP flow, with vlan tag */
 	MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG,
-		       MVPP22_CLS_HEK_OPT_VLAN,
+		       MVPP22_CLS_HEK_TAGGED,
 		       0, 0),
 };
 
-- 
2.25.1

Re: [PATCH v2] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

Posted by Maxime Chevallier 9 months, 3 weeks ago

On Mon, 24 Feb 2025 20:20:58 -0800
Harshal Chaudhari <hchaudhari@marvell.com> wrote:

> Non IP flow, with vlan tag not working as expected while
> running below command for vlan-priority. fixed that.
> 
> ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0
> 
> Fixes: 1274daede3ef ("net: mvpp2: cls: Add steering based on vlan Id and priority.")
> Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Thank you,

Maxime