[PATCH 2/7] regulator: act8865-regulator: switch psy_cfg from of_node to fwnode

Sebastian Reichel posted 7 patches 11 months, 2 weeks ago
There is a newer version of this series
[PATCH 2/7] regulator: act8865-regulator: switch psy_cfg from of_node to fwnode
Posted by Sebastian Reichel 11 months, 2 weeks ago
In order to remove .of_node from the power_supply_config struct,
use .fwnode instead.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 drivers/regulator/act8865-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index 0457af23c55acdd97b2cdc6fd6bfd07ae0f9d11f..b2a6ddc6f56d32e8758977e25858b972e294bc84 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -643,7 +643,7 @@ static int act8600_charger_probe(struct device *dev, struct regmap *regmap)
 	struct power_supply *charger;
 	struct power_supply_config cfg = {
 		.drv_data = regmap,
-		.of_node = dev->of_node,
+		.fwnode = dev_fwnode(dev),
 	};
 
 	charger = devm_power_supply_register(dev, &act8600_charger_desc, &cfg);

-- 
2.47.2
Re: [PATCH 2/7] regulator: act8865-regulator: switch psy_cfg from of_node to fwnode
Posted by Sebastian Reichel 11 months ago
Hello Mark,

On Tue, Feb 25, 2025 at 12:21:35AM +0100, Sebastian Reichel wrote:
> In order to remove .of_node from the power_supply_config struct,
> use .fwnode instead.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---

Can you apply this trivial patch for 6.15, so that we don't have to
bother with an immutable branch for the remaining series in the 6.16
cycle? In case the patch itself did not reach you for some reason:

b4 am --single-message "20250225-psy-core-convert-to-fwnode-v1-2-d5e4369936bb@collabora.com"

Thanks,

-- Sebastian

>  drivers/regulator/act8865-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
> index 0457af23c55acdd97b2cdc6fd6bfd07ae0f9d11f..b2a6ddc6f56d32e8758977e25858b972e294bc84 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -643,7 +643,7 @@ static int act8600_charger_probe(struct device *dev, struct regmap *regmap)
>  	struct power_supply *charger;
>  	struct power_supply_config cfg = {
>  		.drv_data = regmap,
> -		.of_node = dev->of_node,
> +		.fwnode = dev_fwnode(dev),
>  	};
>  
>  	charger = devm_power_supply_register(dev, &act8600_charger_desc, &cfg);
> 
> -- 
> 2.47.2
> 
Re: [PATCH 2/7] regulator: act8865-regulator: switch psy_cfg from of_node to fwnode
Posted by Mark Brown 11 months ago
On Wed, Mar 12, 2025 at 01:12:14AM +0100, Sebastian Reichel wrote:

> Can you apply this trivial patch for 6.15, so that we don't have to
> bother with an immutable branch for the remaining series in the 6.16
> cycle? In case the patch itself did not reach you for some reason:

I have no idea what the story with dependencies is here...

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.