[PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B

Luca Weiss posted 4 patches 11 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B
Posted by Luca Weiss 11 months, 2 weeks ago
Himax HX83112B is a display driver IC used to drive LCD DSI panels.
Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN using
it.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 .../bindings/display/panel/himax,hx83112b.yaml     | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83112b.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83112b.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..54c555c18bbe7656ec625b20e28a53fde5fe578b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx83112b.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/himax,hx83112b.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HX83112B-based DSI display panels
+
+maintainers:
+  - Luca Weiss <luca@lucaweiss.eu>
+
+description:
+  The Himax HX83112B is a generic DSI Panel IC used to control
+  LCD panels.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    contains:
+      const: djn,98-03057-6598b-i
+
+  reg:
+    maxItems: 1
+
+  iovcc-supply:
+    description: I/O voltage rail
+
+  vsn-supply:
+    description: Positive source voltage rail
+
+  vsp-supply:
+    description: Negative source voltage rail
+
+  port: true
+
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - iovcc-supply
+  - vsn-supply
+  - vsp-supply
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "djn,98-03057-6598b-i";
+            reg = <0>;
+
+            reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
+
+            iovcc-supply = <&pm8953_l6>;
+            vsn-supply = <&pmi632_lcdb_ncp>;
+            vsp-supply = <&pmi632_lcdb_ldo>;
+
+            port {
+                panel_in_0: endpoint {
+                    remote-endpoint = <&dsi0_out>;
+                };
+            };
+        };
+    };
+
+...

-- 
2.48.1
Re: [PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B
Posted by Krzysztof Kozlowski 11 months, 2 weeks ago
On Tue, Feb 25, 2025 at 10:14:30PM +0100, Luca Weiss wrote:
> Himax HX83112B is a display driver IC used to drive LCD DSI panels.
> Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN using
> it.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  .../bindings/display/panel/himax,hx83112b.yaml     | 75 ++++++++++++++++++++++
>  1 file changed, 75 insertions(+)
> 

Discussion is still going. Sending v2 after two days is hiding that
previous talk, so that makes me sad.

I am still at v1 and I am not going to review this one here.

Best regards,
Krzysztof
Re: [PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B
Posted by Luca Weiss 9 months ago
Hi Krzysztof,

On 2025-02-26 07:46, Krzysztof Kozlowski wrote:
> On Tue, Feb 25, 2025 at 10:14:30PM +0100, Luca Weiss wrote:
>> Himax HX83112B is a display driver IC used to drive LCD DSI panels.
>> Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN 
>> using
>> it.
>> 
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>>  .../bindings/display/panel/himax,hx83112b.yaml     | 75 
>> ++++++++++++++++++++++
>>  1 file changed, 75 insertions(+)
>> 
> 
> Discussion is still going. Sending v2 after two days is hiding that
> previous talk, so that makes me sad.
> 
> I am still at v1 and I am not going to review this one here.

Apart from [0] there was also no other activity in v1, could you take 
another look now?

[0] 
https://lore.kernel.org/linux-arm-msm/emwpl2e7zpzkm4uea22g4hayz66nk7nxylinsd2stuwlatwdc3@ixkbc2bxbz4p/

Regards
Luca

> 
> Best regards,
> Krzysztof
Re: [PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B
Posted by Krzysztof Kozlowski 8 months, 2 weeks ago
On 14/05/2025 16:31, Luca Weiss wrote:
> Hi Krzysztof,
> 
> On 2025-02-26 07:46, Krzysztof Kozlowski wrote:
>> On Tue, Feb 25, 2025 at 10:14:30PM +0100, Luca Weiss wrote:
>>> Himax HX83112B is a display driver IC used to drive LCD DSI panels.
>>> Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN 
>>> using
>>> it.
>>>
>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>> ---
>>>  .../bindings/display/panel/himax,hx83112b.yaml     | 75 
>>> ++++++++++++++++++++++
>>>  1 file changed, 75 insertions(+)
>>>
>>
>> Discussion is still going. Sending v2 after two days is hiding that
>> previous talk, so that makes me sad.
>>
>> I am still at v1 and I am not going to review this one here.
> 
> Apart from [0] there was also no other activity in v1, could you take 
> another look now?
> 
Keep only one compatible, so no himax fallback. This patchset rolled out
of my inbox, so please send v3 or resend with short explanation in
commit msg (no init sequence for generic himax, like you described in v1
discussion).

Best regards,
Krzysztof
Re: [PATCH v2 2/4] dt-bindings: display: panel: Add Himax HX83112B
Posted by Luca Weiss 11 months, 2 weeks ago
On 26-02-2025 8:46 a.m., Krzysztof Kozlowski wrote:
> On Tue, Feb 25, 2025 at 10:14:30PM +0100, Luca Weiss wrote:
>> Himax HX83112B is a display driver IC used to drive LCD DSI panels.
>> Describe it and the Fairphone 3 panel (98-03057-6598B-I) from DJN using
>> it.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>>   .../bindings/display/panel/himax,hx83112b.yaml     | 75 ++++++++++++++++++++++
>>   1 file changed, 75 insertions(+)
>>
> 
> Discussion is still going. Sending v2 after two days is hiding that
> previous talk, so that makes me sad.
> 
> I am still at v1 and I am not going to review this one here.

Sorry about that. I'm going to be away/not have time for kernel dev for 
the next ~1.5 weeks so I thought I'd send v2 with the updated compatible 
string already.

Regards
Luca

> 
> Best regards,
> Krzysztof
>