[PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant

Krzysztof Kozlowski posted 13 patches 9 months, 3 weeks ago
arch/arm/boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi         | 2 +-
arch/arm/boot/dts/qcom/qcom-ipq4018-jalapeno.dts           | 4 ++--
arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts       | 2 +-
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts         | 2 +-
arch/arm64/boot/dts/qcom/qcm6490-idp.dts                   | 2 +-
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts           | 2 +-
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts               | 2 +-
arch/arm64/boot/dts/qcom/qrb2210-rb1.dts                   | 2 +-
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts                   | 2 +-
arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi                 | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi      | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts     | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi         | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi    | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi        | 2 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi   | 2 +-
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts                  | 2 +-
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts     | 2 +-
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts  | 2 +-
arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts        | 2 +-
arch/arm64/boot/dts/qcom/sdm845-db845c.dts                 | 2 +-
arch/arm64/boot/dts/qcom/sdm845-mtp.dts                    | 2 +-
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts       | 2 +-
arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts            | 2 +-
arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts          | 2 +-
arch/arm64/boot/dts/qcom/sm8150-hdk.dts                    | 2 +-
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi   | 2 +-
28 files changed, 29 insertions(+), 29 deletions(-)
[PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Krzysztof Kozlowski 9 months, 3 weeks ago
Dependency
==========
RFC, because this should be merged release after driver support is
merged:
https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t

Change will affect out of tree users, like other projects, of this DTS.

Description
===========
The property qcom,ath10k/11k-calibration-variant was deprecated in favor
of recently introduced generic qcom,calibration-variant, common to all
Qualcomm Atheros WiFi bindings.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (13):
      ARM: dts: qcom: ipq4018: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: msm8998: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: qrb2210-rb1: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: qrb4210-rb2: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sc7180: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sdm845: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sda660-ifc6560: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sm6115: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sm8150-hdk: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: qcm6490: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sa8775p-ride: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sc8280xp: Switch to undeprecated qcom,calibration-variant
      arm64: dts: qcom: sm8250-elish: Switch to undeprecated qcom,calibration-variant

 arch/arm/boot/dts/qcom/qcom-ipq4018-ap120c-ac.dtsi         | 2 +-
 arch/arm/boot/dts/qcom/qcom-ipq4018-jalapeno.dts           | 4 ++--
 arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts       | 2 +-
 arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts         | 2 +-
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts                   | 2 +-
 arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts           | 2 +-
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts               | 2 +-
 arch/arm64/boot/dts/qcom/qrb2210-rb1.dts                   | 2 +-
 arch/arm64/boot/dts/qcom/qrb4210-rb2.dts                   | 2 +-
 arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi                 | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi      | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts     | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi         | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi    | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi        | 2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi   | 2 +-
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts                  | 2 +-
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
 arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts     | 2 +-
 arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts  | 2 +-
 arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts        | 2 +-
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts                 | 2 +-
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts                    | 2 +-
 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts       | 2 +-
 arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts            | 2 +-
 arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts          | 2 +-
 arch/arm64/boot/dts/qcom/sm8150-hdk.dts                    | 2 +-
 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi   | 2 +-
 28 files changed, 29 insertions(+), 29 deletions(-)
---
base-commit: 0b711700b3e432d036512ecd580d1312707a11da
change-id: 20250225-dts-qcom-wifi-calibration-a3aa0094e731
prerequisite-change-id: 20250225-b-wifi-qcom-calibration-variant-92a02995e996:v1
prerequisite-patch-id: 3d5e2355edb04751d04c86263d1aadba0f309fc9
prerequisite-patch-id: 939f220d1859ffb79d2d74d38b8ebdafd5e11925
prerequisite-patch-id: ccc166b6ad2f1c967750b06bf6ab543f22590776
prerequisite-patch-id: f05f46fc9b19b4b48114950c9c86c849e52fbfca
prerequisite-patch-id: 3c61783975dc22358e7817c8ed549334135a2d2a

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Krzysztof Kozlowski 8 months, 3 weeks ago
On 25/02/2025 10:58, Krzysztof Kozlowski wrote:
> Dependency
> ==========
> RFC, because this should be merged release after driver support is
> merged:
> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
> 
> Change will affect out of tree users, like other projects, of this DTS.
> 
> Description
> ===========
> The property qcom,ath10k/11k-calibration-variant was deprecated in favor
> of recently introduced generic qcom,calibration-variant, common to all
> Qualcomm Atheros WiFi bindings.

Above changes were merged to mainline, thus patchset is safe now to be
applied (as far as Linux is concerned).

Best regards,
Krzysztof
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Bjorn Andersson 9 months, 2 weeks ago
On Tue, 25 Feb 2025 10:58:57 +0100, Krzysztof Kozlowski wrote:
> Dependency
> ==========
> RFC, because this should be merged release after driver support is
> merged:
> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
> 
> Change will affect out of tree users, like other projects, of this DTS.
> 
> [...]

Applied, thanks!

[01/13] ARM: dts: qcom: ipq4018: Switch to undeprecated qcom,calibration-variant
        commit: adbbdcf4b2d6556721b580385ba387baca5c26ee
[02/13] arm64: dts: qcom: msm8998: Switch to undeprecated qcom,calibration-variant
        commit: f1bf8a943bea70c7432731c11761d161882aeedc
[03/13] arm64: dts: qcom: qrb2210-rb1: Switch to undeprecated qcom,calibration-variant
        commit: 41eeff2fc2292c56592206741b05fde63acef4f0
[04/13] arm64: dts: qcom: qrb4210-rb2: Switch to undeprecated qcom,calibration-variant
        commit: a83356f7ba575f536dd2bf2338cafd0d1d2d51ec
[05/13] arm64: dts: qcom: sc7180: Switch to undeprecated qcom,calibration-variant
        commit: 4f8fc2038b3ce9fa1fd52491e774e43bf5e67547
[06/13] arm64: dts: qcom: sdm845: Switch to undeprecated qcom,calibration-variant
        commit: 218718e0c2536bc17c1a10eed35e99100bed5b46
[07/13] arm64: dts: qcom: sda660-ifc6560: Switch to undeprecated qcom,calibration-variant
        commit: 020ec05884e97175a181b33eb60d556ceaa32de8
[08/13] arm64: dts: qcom: sm6115: Switch to undeprecated qcom,calibration-variant
        commit: d39d4fd49337be1e8f6c28e4d31344a2124acb57
[09/13] arm64: dts: qcom: sm8150-hdk: Switch to undeprecated qcom,calibration-variant
        commit: b187df5a0224d2e1b5ab8ea19c98d6ebbe554fe8
[10/13] arm64: dts: qcom: qcm6490: Switch to undeprecated qcom,calibration-variant
        commit: cfbcd6d483dc7203db230cb24c9ee286033682fa
[11/13] arm64: dts: qcom: sa8775p-ride: Switch to undeprecated qcom,calibration-variant
        commit: fda76284e9b4c4606758fb62cfd81dd57e8f2516
[12/13] arm64: dts: qcom: sc8280xp: Switch to undeprecated qcom,calibration-variant
        commit: d12ce84c88013cd4ea770d244d44362f691e1690
[13/13] arm64: dts: qcom: sm8250-elish: Switch to undeprecated qcom,calibration-variant
        commit: 37eb85ae550004790c98605762c2e0326a82e160

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Dmitry Baryshkov 9 months, 2 weeks ago
On Tue, Mar 04, 2025 at 11:00:10AM -0600, Bjorn Andersson wrote:
> 
> On Tue, 25 Feb 2025 10:58:57 +0100, Krzysztof Kozlowski wrote:
> > Dependency
> > ==========
> > RFC, because this should be merged release after driver support is
> > merged:
> > https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
> > 
> > Change will affect out of tree users, like other projects, of this DTS.
> > 
> > [...]
> 
> Applied, thanks!

Applying it too early might break WiFi on those boards. I think
Krzysztof explicitly asked for it to be merged in +1 release, when the
driver changes are in.

> 
> [01/13] ARM: dts: qcom: ipq4018: Switch to undeprecated qcom,calibration-variant
>         commit: adbbdcf4b2d6556721b580385ba387baca5c26ee
> [02/13] arm64: dts: qcom: msm8998: Switch to undeprecated qcom,calibration-variant
>         commit: f1bf8a943bea70c7432731c11761d161882aeedc
> [03/13] arm64: dts: qcom: qrb2210-rb1: Switch to undeprecated qcom,calibration-variant
>         commit: 41eeff2fc2292c56592206741b05fde63acef4f0
> [04/13] arm64: dts: qcom: qrb4210-rb2: Switch to undeprecated qcom,calibration-variant
>         commit: a83356f7ba575f536dd2bf2338cafd0d1d2d51ec
> [05/13] arm64: dts: qcom: sc7180: Switch to undeprecated qcom,calibration-variant
>         commit: 4f8fc2038b3ce9fa1fd52491e774e43bf5e67547
> [06/13] arm64: dts: qcom: sdm845: Switch to undeprecated qcom,calibration-variant
>         commit: 218718e0c2536bc17c1a10eed35e99100bed5b46
> [07/13] arm64: dts: qcom: sda660-ifc6560: Switch to undeprecated qcom,calibration-variant
>         commit: 020ec05884e97175a181b33eb60d556ceaa32de8
> [08/13] arm64: dts: qcom: sm6115: Switch to undeprecated qcom,calibration-variant
>         commit: d39d4fd49337be1e8f6c28e4d31344a2124acb57
> [09/13] arm64: dts: qcom: sm8150-hdk: Switch to undeprecated qcom,calibration-variant
>         commit: b187df5a0224d2e1b5ab8ea19c98d6ebbe554fe8
> [10/13] arm64: dts: qcom: qcm6490: Switch to undeprecated qcom,calibration-variant
>         commit: cfbcd6d483dc7203db230cb24c9ee286033682fa
> [11/13] arm64: dts: qcom: sa8775p-ride: Switch to undeprecated qcom,calibration-variant
>         commit: fda76284e9b4c4606758fb62cfd81dd57e8f2516
> [12/13] arm64: dts: qcom: sc8280xp: Switch to undeprecated qcom,calibration-variant
>         commit: d12ce84c88013cd4ea770d244d44362f691e1690
> [13/13] arm64: dts: qcom: sm8250-elish: Switch to undeprecated qcom,calibration-variant
>         commit: 37eb85ae550004790c98605762c2e0326a82e160
> 
> Best regards,
> -- 
> Bjorn Andersson <andersson@kernel.org>

-- 
With best wishes
Dmitry
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Krzysztof Kozlowski 9 months, 2 weeks ago
On 04/03/2025 21:50, Dmitry Baryshkov wrote:
> On Tue, Mar 04, 2025 at 11:00:10AM -0600, Bjorn Andersson wrote:
>>
>> On Tue, 25 Feb 2025 10:58:57 +0100, Krzysztof Kozlowski wrote:
>>> Dependency
>>> ==========
>>> RFC, because this should be merged release after driver support is
>>> merged:
>>> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
>>>
>>> Change will affect out of tree users, like other projects, of this DTS.
>>>
>>> [...]
>>
>> Applied, thanks!
> 
> Applying it too early might break WiFi on those boards. I think

It is just non-bisectable, so that's why I put above remark.

> Krzysztof explicitly asked for it to be merged in +1 release, when the
> driver changes are in.

Yeah, that was the point.


Best regards,
Krzysztof
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Jeff Johnson 9 months, 2 weeks ago
On 3/4/2025 10:48 PM, Krzysztof Kozlowski wrote:
> On 04/03/2025 21:50, Dmitry Baryshkov wrote:
>> On Tue, Mar 04, 2025 at 11:00:10AM -0600, Bjorn Andersson wrote:
>>>
>>> On Tue, 25 Feb 2025 10:58:57 +0100, Krzysztof Kozlowski wrote:
>>>> Dependency
>>>> ==========
>>>> RFC, because this should be merged release after driver support is
>>>> merged:
>>>> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
>>>>
>>>> Change will affect out of tree users, like other projects, of this DTS.
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>
>> Applying it too early might break WiFi on those boards. I think
> 
> It is just non-bisectable, so that's why I put above remark.
> 
>> Krzysztof explicitly asked for it to be merged in +1 release, when the
>> driver changes are in.
> 
> Yeah, that was the point.

Driver changes are already in linux-next, and I've sent the pull request to
linux-wireless to hopefully have those changes land in the 6.15 merge window.
(ath => wireless => net => Linus)

/jeff
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Dmitry Baryshkov 9 months, 2 weeks ago
On Thu, 6 Mar 2025 at 19:16, Jeff Johnson <jeff.johnson@oss.qualcomm.com> wrote:
>
> On 3/4/2025 10:48 PM, Krzysztof Kozlowski wrote:
> > On 04/03/2025 21:50, Dmitry Baryshkov wrote:
> >> On Tue, Mar 04, 2025 at 11:00:10AM -0600, Bjorn Andersson wrote:
> >>>
> >>> On Tue, 25 Feb 2025 10:58:57 +0100, Krzysztof Kozlowski wrote:
> >>>> Dependency
> >>>> ==========
> >>>> RFC, because this should be merged release after driver support is
> >>>> merged:
> >>>> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
> >>>>
> >>>> Change will affect out of tree users, like other projects, of this DTS.
> >>>>
> >>>> [...]
> >>>
> >>> Applied, thanks!
> >>
> >> Applying it too early might break WiFi on those boards. I think
> >
> > It is just non-bisectable, so that's why I put above remark.
> >
> >> Krzysztof explicitly asked for it to be merged in +1 release, when the
> >> driver changes are in.
> >
> > Yeah, that was the point.
>
> Driver changes are already in linux-next, and I've sent the pull request to
> linux-wireless to hopefully have those changes land in the 6.15 merge window.
> (ath => wireless => net => Linus)

But if anything, bisecting over Bjorn's tree might give strange results.


-- 
With best wishes
Dmitry
Re: [PATCH RFC 00/13] arm: dts: qcom: Switch to undeprecated qcom,calibration-variant
Posted by Konrad Dybcio 9 months, 3 weeks ago
On 25.02.2025 10:58 AM, Krzysztof Kozlowski wrote:
> Dependency
> ==========
> RFC, because this should be merged release after driver support is
> merged:
> https://lore.kernel.org/linux-devicetree/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org/T/#t
> 
> Change will affect out of tree users, like other projects, of this DTS.

That's a good cleanup, too bad nobody thought of that before

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad