The off_gpios could be NULL. Add missing check in the kb3930_probe().
This is similar to the issue fixed in commit b1ba8bcb2d1f
("backlight: hx8357: Fix potential NULL pointer dereference").

This was detected by our static analysis tool.

Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Suggested-by: Lee Jones <lee@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/mfd/ene-kb3930.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index fa0ad2f14a39..9460a67acb0b 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -162,7 +162,7 @@ static int kb3930_probe(struct i2c_client *client)
 			devm_gpiod_get_array_optional(dev, "off", GPIOD_IN);
 		if (IS_ERR(ddata->off_gpios))
 			return PTR_ERR(ddata->off_gpios);
-		if (ddata->off_gpios->ndescs < 2) {
+		if (ddata->off_gpios && ddata->off_gpios->ndescs < 2) {
 			dev_err(dev, "invalid off-gpios property\n");
 			return -EINVAL;
 		}
-- 
2.34.1

On Mon, 24 Feb 2025 17:37:36 -0600, Chenyuan Yang wrote:
> The off_gpios could be NULL. Add missing check in the kb3930_probe().
> This is similar to the issue fixed in commit b1ba8bcb2d1f
> ("backlight: hx8357: Fix potential NULL pointer dereference").
> 
> This was detected by our static analysis tool.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: ene-kb3930: Fix a potential NULL pointer dereference
      commit: 61234ece5d37b3c1dce388cdb85fea4d9246318a

--
Lee Jones [李琼斯]