The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
hd44780_common") makes charlcd_alloc() argument-less effectively dropping
the single allocation for the struct charlcd_priv object along with
the driver specific one. Restore that behaviour here.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/auxdisplay/charlcd.c | 5 +++--
drivers/auxdisplay/charlcd.h | 5 +++--
drivers/auxdisplay/hd44780.c | 2 +-
drivers/auxdisplay/lcd2s.c | 2 +-
drivers/auxdisplay/panel.c | 2 +-
5 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index 19b619376d48..09020bb8ad15 100644
--- a/drivers/auxdisplay/charlcd.c
+++ b/drivers/auxdisplay/charlcd.c
@@ -595,18 +595,19 @@ static int charlcd_init(struct charlcd *lcd)
return 0;
}
-struct charlcd *charlcd_alloc(void)
+struct charlcd *charlcd_alloc(unsigned int drvdata_size)
{
struct charlcd_priv *priv;
struct charlcd *lcd;
- priv = kzalloc(sizeof(*priv), GFP_KERNEL);
+ priv = kzalloc(sizeof(*priv) + drvdata_size, GFP_KERNEL);
if (!priv)
return NULL;
priv->esc_seq.len = -1;
lcd = &priv->lcd;
+ lcd->drvdata = priv->drvdata;
return lcd;
}
diff --git a/drivers/auxdisplay/charlcd.h b/drivers/auxdisplay/charlcd.h
index 4d4287209d04..d10b89740bca 100644
--- a/drivers/auxdisplay/charlcd.h
+++ b/drivers/auxdisplay/charlcd.h
@@ -51,7 +51,7 @@ struct charlcd {
unsigned long y;
} addr;
- void *drvdata;
+ void *drvdata; /* Set by charlcd_alloc() */
};
/**
@@ -95,7 +95,8 @@ struct charlcd_ops {
};
void charlcd_backlight(struct charlcd *lcd, enum charlcd_onoff on);
-struct charlcd *charlcd_alloc(void);
+
+struct charlcd *charlcd_alloc(unsigned int drvdata_size);
void charlcd_free(struct charlcd *lcd);
int charlcd_register(struct charlcd *lcd);
diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 9d0ae9c02e9b..1d67fe324341 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -226,7 +226,7 @@ static int hd44780_probe(struct platform_device *pdev)
if (!hdc)
return -ENOMEM;
- lcd = charlcd_alloc();
+ lcd = charlcd_alloc(0);
if (!lcd)
goto fail1;
diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c
index f831ce762508..d573d36e3067 100644
--- a/drivers/auxdisplay/lcd2s.c
+++ b/drivers/auxdisplay/lcd2s.c
@@ -310,7 +310,7 @@ static int lcd2s_i2c_probe(struct i2c_client *i2c)
if (err < 0)
return err;
- lcd = charlcd_alloc();
+ lcd = charlcd_alloc(0);
if (!lcd)
return -ENOMEM;
diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index 6dc8798d01f9..4da142692d55 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -835,7 +835,7 @@ static void lcd_init(void)
if (!hdc)
return;
- charlcd = charlcd_alloc();
+ charlcd = charlcd_alloc(0);
if (!charlcd) {
kfree(hdc);
return;
--
2.45.1.3035.g276e886db78bHi Andy,
Thanks for your patch!
On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
s/The commit/Commit/
> hd44780_common") makes charlcd_alloc() argument-less effectively dropping
> the single allocation for the struct charlcd_priv object along with
> the driver specific one. Restore that behaviour here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
> On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
>
> s/The commit/Commit/
Why? We know that we are talking about the very specific commit.
My English is not native I would appreciate a link to a material to study
the case you pointed out.
> > hd44780_common") makes charlcd_alloc() argument-less effectively dropping
> > the single allocation for the struct charlcd_priv object along with
> > the driver specific one. Restore that behaviour here.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks!
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> >
> > s/The commit/Commit/
>
> Why? We know that we are talking about the very specific commit.
You can have a noun with or without an article:
- "a commit": an unspecified commit,
- "the commit": a specific commit, specified by context.
- "commit 1234abcd": a specific commit, specified by what follows.
> My English is not native I would appreciate a link to a material to study
> the case you pointed out.
Neither is mine, but the use of articles is similar in English and Dutch.
(I am aware your mother tongue does not have articles ;-)
I found plenty of articles explaining cases 1 and 2.
Case 3 can be considered equivalent to "Mount Everest" in
https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > >
> > > s/The commit/Commit/
> >
> > Why? We know that we are talking about the very specific commit.
>
> You can have a noun with or without an article:
This is not so simple :-), esp. if a noun is a weekday or a toponym.
> - "a commit": an unspecified commit,
> - "the commit": a specific commit, specified by context.
> - "commit 1234abcd": a specific commit, specified by what follows.
>
> > My English is not native I would appreciate a link to a material to study
> > the case you pointed out.
>
> Neither is mine, but the use of articles is similar in English and Dutch.
> (I am aware your mother tongue does not have articles ;-)
>
> I found plenty of articles explaining cases 1 and 2.
> Case 3 can be considered equivalent to "Mount Everest" in
> https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
Okay, so you actually think that the hash and the title can be considered as
"name of a place". Hmm... I don't think it applies here. It's not a place.
Moreover some places require "the" article.
Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
for example, the sentence "The 2003 federal budget" sounds to me closer to
our case. Every year there is a federal budget, but we explicitly point out
to one and reader knows what is this. The same with the commit.
Sorry, but I am still not convinced.
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On Fri, 7 Mar 2025 at 19:57, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> > On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > > >
> > > > s/The commit/Commit/
> > >
> > > Why? We know that we are talking about the very specific commit.
> >
> > You can have a noun with or without an article:
>
> This is not so simple :-), esp. if a noun is a weekday or a toponym.
>
> > - "a commit": an unspecified commit,
> > - "the commit": a specific commit, specified by context.
> > - "commit 1234abcd": a specific commit, specified by what follows.
> >
> > > My English is not native I would appreciate a link to a material to study
> > > the case you pointed out.
> >
> > Neither is mine, but the use of articles is similar in English and Dutch.
> > (I am aware your mother tongue does not have articles ;-)
> >
> > I found plenty of articles explaining cases 1 and 2.
> > Case 3 can be considered equivalent to "Mount Everest" in
> > https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
>
> Okay, so you actually think that the hash and the title can be considered as
> "name of a place". Hmm... I don't think it applies here. It's not a place.
> Moreover some places require "the" article.
Only if they are a region, not if they are a country (yes, that's
unrelated here).
> Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
> for example, the sentence "The 2003 federal budget" sounds to me closer to
> our case. Every year there is a federal budget, but we explicitly point out
> to one and reader knows what is this. The same with the commit.
>
> Sorry, but I am still not convinced.
In "The 2003 federal budget", both "2003" and "federal" are adjectives.
In "commit 1234abcd", "1234abcd" is a name.
Cfr. "King Charles". "The King Charles" would be used only when
putting a very special emphasis on "king".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Fri, Mar 07, 2025 at 08:05:56PM +0100, Geert Uytterhoeven wrote:
> On Fri, 7 Mar 2025 at 19:57, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > > > >
> > > > > s/The commit/Commit/
> > > >
> > > > Why? We know that we are talking about the very specific commit.
> > >
> > > You can have a noun with or without an article:
> >
> > This is not so simple :-), esp. if a noun is a weekday or a toponym.
> >
> > > - "a commit": an unspecified commit,
> > > - "the commit": a specific commit, specified by context.
> > > - "commit 1234abcd": a specific commit, specified by what follows.
> > >
> > > > My English is not native I would appreciate a link to a material to study
> > > > the case you pointed out.
> > >
> > > Neither is mine, but the use of articles is similar in English and Dutch.
> > > (I am aware your mother tongue does not have articles ;-)
> > >
> > > I found plenty of articles explaining cases 1 and 2.
> > > Case 3 can be considered equivalent to "Mount Everest" in
> > > https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
> >
> > Okay, so you actually think that the hash and the title can be considered as
> > "name of a place". Hmm... I don't think it applies here. It's not a place.
> > Moreover some places require "the" article.
>
> Only if they are a region, not if they are a country (yes, that's
> unrelated here).
>
> > Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
> > for example, the sentence "The 2003 federal budget" sounds to me closer to
> > our case. Every year there is a federal budget, but we explicitly point out
> > to one and reader knows what is this. The same with the commit.
> >
> > Sorry, but I am still not convinced.
>
> In "The 2003 federal budget", both "2003" and "federal" are adjectives.
> In "commit 1234abcd", "1234abcd" is a name.
>
> Cfr. "King Charles". "The King Charles" would be used only when
> putting a very special emphasis on "king".
I have talked to the language teacher (okay, her native is not English),
and she told me that no article is for the cases of location, person, or
character. None of that category the commit falls into.
So, still not convinced.
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On Mon, 10 Mar 2025 at 09:12, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Mar 07, 2025 at 08:05:56PM +0100, Geert Uytterhoeven wrote:
> > On Fri, 7 Mar 2025 at 19:57, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> > > > On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > > > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > > > > >
> > > > > > s/The commit/Commit/
> > > > >
> > > > > Why? We know that we are talking about the very specific commit.
> > > >
> > > > You can have a noun with or without an article:
> > >
> > > This is not so simple :-), esp. if a noun is a weekday or a toponym.
> > >
> > > > - "a commit": an unspecified commit,
> > > > - "the commit": a specific commit, specified by context.
> > > > - "commit 1234abcd": a specific commit, specified by what follows.
> > > >
> > > > > My English is not native I would appreciate a link to a material to study
> > > > > the case you pointed out.
> > > >
> > > > Neither is mine, but the use of articles is similar in English and Dutch.
> > > > (I am aware your mother tongue does not have articles ;-)
> > > >
> > > > I found plenty of articles explaining cases 1 and 2.
> > > > Case 3 can be considered equivalent to "Mount Everest" in
> > > > https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
> > >
> > > Okay, so you actually think that the hash and the title can be considered as
> > > "name of a place". Hmm... I don't think it applies here. It's not a place.
> > > Moreover some places require "the" article.
> >
> > Only if they are a region, not if they are a country (yes, that's
> > unrelated here).
> >
> > > Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
> > > for example, the sentence "The 2003 federal budget" sounds to me closer to
> > > our case. Every year there is a federal budget, but we explicitly point out
> > > to one and reader knows what is this. The same with the commit.
> > >
> > > Sorry, but I am still not convinced.
> >
> > In "The 2003 federal budget", both "2003" and "federal" are adjectives.
> > In "commit 1234abcd", "1234abcd" is a name.
> >
> > Cfr. "King Charles". "The King Charles" would be used only when
> > putting a very special emphasis on "king".
>
> I have talked to the language teacher (okay, her native is not English),
> and she told me that no article is for the cases of location, person, or
> character. None of that category the commit falls into.
>
> So, still not convinced.
I have a hard time finding the official rule (git commits did not
exist when English grammar was written ;-)... Examples are easier to
find. E.g. the first sentence on [1] does not start with an article:
European route E40 is the longest European route.
[1] https://en.wikipedia.org/wiki/European_route_E40
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Mon, Mar 10, 2025 at 10:39:49AM +0100, Geert Uytterhoeven wrote:
> On Mon, 10 Mar 2025 at 09:12, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Mar 07, 2025 at 08:05:56PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, 7 Mar 2025 at 19:57, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> > > > > On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > > > > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > > > > > >
> > > > > > > s/The commit/Commit/
> > > > > >
> > > > > > Why? We know that we are talking about the very specific commit.
> > > > >
> > > > > You can have a noun with or without an article:
> > > >
> > > > This is not so simple :-), esp. if a noun is a weekday or a toponym.
> > > >
> > > > > - "a commit": an unspecified commit,
> > > > > - "the commit": a specific commit, specified by context.
> > > > > - "commit 1234abcd": a specific commit, specified by what follows.
> > > > >
> > > > > > My English is not native I would appreciate a link to a material to study
> > > > > > the case you pointed out.
> > > > >
> > > > > Neither is mine, but the use of articles is similar in English and Dutch.
> > > > > (I am aware your mother tongue does not have articles ;-)
> > > > >
> > > > > I found plenty of articles explaining cases 1 and 2.
> > > > > Case 3 can be considered equivalent to "Mount Everest" in
> > > > > https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
> > > >
> > > > Okay, so you actually think that the hash and the title can be considered as
> > > > "name of a place". Hmm... I don't think it applies here. It's not a place.
> > > > Moreover some places require "the" article.
> > >
> > > Only if they are a region, not if they are a country (yes, that's
> > > unrelated here).
> > >
> > > > Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
> > > > for example, the sentence "The 2003 federal budget" sounds to me closer to
> > > > our case. Every year there is a federal budget, but we explicitly point out
> > > > to one and reader knows what is this. The same with the commit.
> > > >
> > > > Sorry, but I am still not convinced.
> > >
> > > In "The 2003 federal budget", both "2003" and "federal" are adjectives.
> > > In "commit 1234abcd", "1234abcd" is a name.
> > >
> > > Cfr. "King Charles". "The King Charles" would be used only when
> > > putting a very special emphasis on "king".
> >
> > I have talked to the language teacher (okay, her native is not English),
> > and she told me that no article is for the cases of location, person, or
> > character. None of that category the commit falls into.
> >
> > So, still not convinced.
>
> I have a hard time finding the official rule (git commits did not
> exist when English grammar was written ;-)... Examples are easier to
> find. E.g. the first sentence on [1] does not start with an article:
>
> European route E40 is the longest European route.
Okay, seems AI may help here. It tells that grammatically article is needed,
but in technical texts (like this one) it's the usual case to drop it and
it's considered grammatically correct.
We both are right but from different angles. And yours seems the winner today
:)
I'll update the message accordingly.
> [1] https://en.wikipedia.org/wiki/European_route_E40
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 10, 2025 at 10:39:49AM +0100, Geert Uytterhoeven wrote:
> On Mon, 10 Mar 2025 at 09:12, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Mar 07, 2025 at 08:05:56PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, 7 Mar 2025 at 19:57, Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> > > > > On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > > > > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > > > > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > > > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > > > > > >
> > > > > > > s/The commit/Commit/
> > > > > >
> > > > > > Why? We know that we are talking about the very specific commit.
> > > > >
> > > > > You can have a noun with or without an article:
> > > >
> > > > This is not so simple :-), esp. if a noun is a weekday or a toponym.
> > > >
> > > > > - "a commit": an unspecified commit,
> > > > > - "the commit": a specific commit, specified by context.
> > > > > - "commit 1234abcd": a specific commit, specified by what follows.
> > > > >
> > > > > > My English is not native I would appreciate a link to a material to study
> > > > > > the case you pointed out.
> > > > >
> > > > > Neither is mine, but the use of articles is similar in English and Dutch.
> > > > > (I am aware your mother tongue does not have articles ;-)
> > > > >
> > > > > I found plenty of articles explaining cases 1 and 2.
> > > > > Case 3 can be considered equivalent to "Mount Everest" in
> > > > > https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article
> > > >
> > > > Okay, so you actually think that the hash and the title can be considered as
> > > > "name of a place". Hmm... I don't think it applies here. It's not a place.
> > > > Moreover some places require "the" article.
> > >
> > > Only if they are a region, not if they are a country (yes, that's
> > > unrelated here).
> > >
> > > > Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
> > > > for example, the sentence "The 2003 federal budget" sounds to me closer to
> > > > our case. Every year there is a federal budget, but we explicitly point out
> > > > to one and reader knows what is this. The same with the commit.
> > > >
> > > > Sorry, but I am still not convinced.
> > >
> > > In "The 2003 federal budget", both "2003" and "federal" are adjectives.
> > > In "commit 1234abcd", "1234abcd" is a name.
> > >
> > > Cfr. "King Charles". "The King Charles" would be used only when
> > > putting a very special emphasis on "king".
> >
> > I have talked to the language teacher (okay, her native is not English),
> > and she told me that no article is for the cases of location, person, or
> > character. None of that category the commit falls into.
> >
> > So, still not convinced.
>
> I have a hard time finding the official rule (git commits did not
> exist when English grammar was written ;-)... Examples are easier to
> find. E.g. the first sentence on [1] does not start with an article:
>
> European route E40 is the longest European route.
I believe this falls to the "location" category.
Can you find something which is not related to geography?
> [1] https://en.wikipedia.org/wiki/European_route_E40
--
With Best Regards,
Andy Shevchenko
© 2016 - 2025 Red Hat, Inc.