[PATCH v1 0/7] auxdisplay: charlcd: Refactor memory allocation

Andy Shevchenko posted 7 patches 9 months, 3 weeks ago
drivers/auxdisplay/charlcd.c        |  5 +++--
drivers/auxdisplay/charlcd.h        |  5 +++--
drivers/auxdisplay/hd44780.c        | 19 ++++++-------------
drivers/auxdisplay/hd44780_common.c | 24 ++++++++++++++++--------
drivers/auxdisplay/hd44780_common.h |  4 +++-
drivers/auxdisplay/lcd2s.c          | 12 ++++--------
drivers/auxdisplay/panel.c          | 17 +++++------------
7 files changed, 40 insertions(+), 46 deletions(-)
[PATCH v1 0/7] auxdisplay: charlcd: Refactor memory allocation
Posted by Andy Shevchenko 9 months, 3 weeks ago
The users of charlcd_alloc() call for additional memory allocation.
We may do it at the time of the main call as many other APIs do.
For this partially revert the change that brought us to the current
state of affairs, and refactor the code based on the original implementation.

Andy Shevchenko (7):
  auxdisplay: charlcd: Partially revert "Move hwidth and bwidth to
    struct hd44780_common"
  auxdisplay: lcd2s: Allocate memory for custom data in charlcd_alloc()
  auxdisplay: hd44780: Introduce hd44780_common_free()
  auxdisplay: hd44780: Make use of hd44780_common_free()
  auxdisplay: panel: Make use of hd44780_common_free()
  auxdisplay: hd44780: Call charlcd_alloc() from hd44780_common_alloc()
  auxdisplay: hd44780: Rename hd to hdc in hd44780_common_alloc()

 drivers/auxdisplay/charlcd.c        |  5 +++--
 drivers/auxdisplay/charlcd.h        |  5 +++--
 drivers/auxdisplay/hd44780.c        | 19 ++++++-------------
 drivers/auxdisplay/hd44780_common.c | 24 ++++++++++++++++--------
 drivers/auxdisplay/hd44780_common.h |  4 +++-
 drivers/auxdisplay/lcd2s.c          | 12 ++++--------
 drivers/auxdisplay/panel.c          | 17 +++++------------
 7 files changed, 40 insertions(+), 46 deletions(-)

-- 
2.45.1.3035.g276e886db78b
Re: [PATCH v1 0/7] auxdisplay: charlcd: Refactor memory allocation
Posted by Andy Shevchenko 9 months, 2 weeks ago
On Mon, Feb 24, 2025 at 07:27:37PM +0200, Andy Shevchenko wrote:
> The users of charlcd_alloc() call for additional memory allocation.
> We may do it at the time of the main call as many other APIs do.
> For this partially revert the change that brought us to the current
> state of affairs, and refactor the code based on the original implementation.

Geert, if you are okay with this series, I want to proceed with it today.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/7] auxdisplay: charlcd: Refactor memory allocation
Posted by Andy Shevchenko 9 months, 2 weeks ago
On Mon, Mar 03, 2025 at 12:30:59PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 24, 2025 at 07:27:37PM +0200, Andy Shevchenko wrote:
> > The users of charlcd_alloc() call for additional memory allocation.
> > We may do it at the time of the main call as many other APIs do.
> > For this partially revert the change that brought us to the current
> > state of affairs, and refactor the code based on the original implementation.
> 
> Geert, if you are okay with this series, I want to proceed with it today.

Pushed to my review and testing queue, thanks!

P.S. If you think this shouldn't have been done, please tell me.

-- 
With Best Regards,
Andy Shevchenko