[PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()

Haoxiang Li posted 1 patch 11 months, 2 weeks ago
drivers/auxdisplay/hd44780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
Posted by Haoxiang Li 11 months, 2 weeks ago
Fix this by using charlcd_free() instead of kfree().

Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
 drivers/auxdisplay/hd44780.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 0526f0d90a79..fcd3780ce5d1 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -328,7 +328,7 @@ static void hd44780_remove(struct platform_device *pdev)
 	kfree(hdc->hd44780);
 	kfree(lcd->drvdata);
 
-	kfree(lcd);
+	charlcd_free(lcd);
 }
 
 static const struct of_device_id hd44780_of_match[] = {
-- 
2.25.1
Re: [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
Posted by Andy Shevchenko 11 months, 2 weeks ago
On Mon, Feb 24, 2025 at 06:00:09PM +0800, Haoxiang Li wrote:
> Fix this by using charlcd_free() instead of kfree().

Please, fold two patches into one and send it as v2. Thank you!

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH] auxdisplay: hd44780: Fix an API misuse in hd44780_remove()
Posted by Andy Shevchenko 11 months, 2 weeks ago
On Mon, Feb 24, 2025 at 12:32:49PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 24, 2025 at 06:00:09PM +0800, Haoxiang Li wrote:
> > Fix this by using charlcd_free() instead of kfree().
> 
> Please, fold two patches into one and send it as v2. Thank you!

Ah, I see it now.

-- 
With Best Regards,
Andy Shevchenko