From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>

Bound coda timeout sysctl writings between SYSCTL_ZERO
and SYSCTL_INT_MAX.

The proc_handler has thus been updated to proc_dointvec_minmax.

Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
---
 fs/coda/sysctl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
index 0df46f09b6cc5..d6f8206c51575 100644
--- a/fs/coda/sysctl.c
+++ b/fs/coda/sysctl.c
@@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
 		.data		= &coda_timeout,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1		= SYSCTL_ZERO,
+		.extra2		= SYSCTL_INT_MAX,
 	},
 	{
 		.procname	= "hard",
-- 
2.48.1

On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@clip-os.org wrote:
> From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> 
> Bound coda timeout sysctl writings between SYSCTL_ZERO
> and SYSCTL_INT_MAX.
> 
> The proc_handler has thus been updated to proc_dointvec_minmax.
> 
> Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> ---
>  fs/coda/sysctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> index 0df46f09b6cc5..d6f8206c51575 100644
> --- a/fs/coda/sysctl.c
> +++ b/fs/coda/sysctl.c
> @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
>  		.data		= &coda_timeout,
I noticed that coda_timeout is an unsigned long. With that in mind I
would change it to unsigned int. It seems to be a value that can be
ranged within [0,INT_MAX]

Best
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
> -		.proc_handler	= proc_dointvec
> +		.proc_handler	= proc_dointvec_minmax,
> +		.extra1		= SYSCTL_ZERO,
> +		.extra2		= SYSCTL_INT_MAX,
>  	},
>  	{
>  		.procname	= "hard",
> -- 
> 2.48.1
> 

-- 

Joel Granados

On Mon, Mar 03, 2025 at 09:16:10AM -0500, Joel Granados wrote:
> On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@clip-os.org wrote:
> > From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> > 
> > Bound coda timeout sysctl writings between SYSCTL_ZERO
> > and SYSCTL_INT_MAX.
> > 
> > The proc_handler has thus been updated to proc_dointvec_minmax.
> > 
> > Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> > ---
> >  fs/coda/sysctl.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> > index 0df46f09b6cc5..d6f8206c51575 100644
> > --- a/fs/coda/sysctl.c
> > +++ b/fs/coda/sysctl.c
> > @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
> >  		.data		= &coda_timeout,
> I noticed that coda_timeout is an unsigned long. With that in mind I
> would change it to unsigned int. It seems to be a value that can be
> ranged within [0,INT_MAX]

That seems fine by me.

It is a timeout in seconds and it is typically set to some value well
under a minute.

Jan

On Mon, Mar 03, 2025 at 09:39:37AM -0500, Jan Harkes wrote:
> On Mon, Mar 03, 2025 at 09:16:10AM -0500, Joel Granados wrote:
> > On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@clip-os.org wrote:
> > > From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> > > 
> > > Bound coda timeout sysctl writings between SYSCTL_ZERO
> > > and SYSCTL_INT_MAX.
> > > 
> > > The proc_handler has thus been updated to proc_dointvec_minmax.
> > > 
> > > Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
> > > ---
> > >  fs/coda/sysctl.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> > > index 0df46f09b6cc5..d6f8206c51575 100644
> > > --- a/fs/coda/sysctl.c
> > > +++ b/fs/coda/sysctl.c
> > > @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
> > >  		.data		= &coda_timeout,
> > I noticed that coda_timeout is an unsigned long. With that in mind I
> > would change it to unsigned int. It seems to be a value that can be
> > ranged within [0,INT_MAX]
> 
> That seems fine by me.
> 
> It is a timeout in seconds and it is typically set to some value well
> under a minute.
> 

Thx for the confirmation. I'll let nicolas take care of the change
Best

-- 

Joel Granados

Hi Jan and Joel,

Thanks for your review,

I'll update coda_timeout type to an unsigned int and push back the patchset
without patches that has moved in their subsystems.

Best regards,

Nicolas

On 3/5/25 15:47, Joel Granados wrote:
> On Mon, Mar 03, 2025 at 09:39:37AM -0500, Jan Harkes wrote:
>> On Mon, Mar 03, 2025 at 09:16:10AM -0500, Joel Granados wrote:
>>> On Mon, Feb 24, 2025 at 10:58:18AM +0100, nicolas.bouchinet@clip-os.org wrote:
>>>> From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
>>>>
>>>> Bound coda timeout sysctl writings between SYSCTL_ZERO
>>>> and SYSCTL_INT_MAX.
>>>>
>>>> The proc_handler has thus been updated to proc_dointvec_minmax.
>>>>
>>>> Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
>>>> ---
>>>>   fs/coda/sysctl.c | 4 +++-
>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
>>>> index 0df46f09b6cc5..d6f8206c51575 100644
>>>> --- a/fs/coda/sysctl.c
>>>> +++ b/fs/coda/sysctl.c
>>>> @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
>>>>   		.data		= &coda_timeout,
>>> I noticed that coda_timeout is an unsigned long. With that in mind I
>>> would change it to unsigned int. It seems to be a value that can be
>>> ranged within [0,INT_MAX]
>> That seems fine by me.
>>
>> It is a timeout in seconds and it is typically set to some value well
>> under a minute.
>>
> Thx for the confirmation. I'll let nicolas take care of the change
> Best
>