[PATCH 1/5] of: Compare property names by of_prop_cmp() in of_alias_scan()

Zijun Hu posted 5 patches 9 months, 3 weeks ago
[PATCH 1/5] of: Compare property names by of_prop_cmp() in of_alias_scan()
Posted by Zijun Hu 9 months, 3 weeks ago
From: Zijun Hu <quic_zijuhu@quicinc.com>

For these pseudo property names 'name', 'phandle' and 'linux,phandle':

Use dedicated property name comparison macro of_prop_cmp() instead of
strcmp() in of_alias_scan() to:

- Make property name comparison consistent.
- Prepare for introducing private is_pseudo_property() later.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/of/base.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index af6c68bbb4277e4f66deef886a2df8d1b6f114cf..d2d41601136bc8ee2b97e31b83af1b361ba03261 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1855,9 +1855,9 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
 		int id, len;
 
 		/* Skip those we do not want to proceed */
-		if (!strcmp(pp->name, "name") ||
-		    !strcmp(pp->name, "phandle") ||
-		    !strcmp(pp->name, "linux,phandle"))
+		if (!of_prop_cmp(pp->name, "name") ||
+		    !of_prop_cmp(pp->name, "phandle") ||
+		    !of_prop_cmp(pp->name, "linux,phandle"))
 			continue;
 
 		np = of_find_node_by_path(pp->value);

-- 
2.34.1
Re: [PATCH 1/5] of: Compare property names by of_prop_cmp() in of_alias_scan()
Posted by Rob Herring (Arm) 9 months, 3 weeks ago
On Mon, 24 Feb 2025 22:27:57 +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> For these pseudo property names 'name', 'phandle' and 'linux,phandle':
> 
> Use dedicated property name comparison macro of_prop_cmp() instead of
> strcmp() in of_alias_scan() to:
> 
> - Make property name comparison consistent.
> - Prepare for introducing private is_pseudo_property() later.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  drivers/of/base.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied, thanks!