[PATCH v2] net: ethernet: ti: am65-cpsw: select PAGE_POOL

Sascha Hauer posted 1 patch 9 months, 3 weeks ago
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Posted by Sascha Hauer 9 months, 3 weeks ago
am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
selected to avoid linker errors. This is missing since the driver
started to use page_pool helpers in 8acacc40f733 ("net: ethernet:
ti: am65-cpsw: Add minimal XDP support")

Fixes: 8acacc40f733 ("net: ethernet: ti: am65-cpsw: Add minimal XDP support")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Changes in v2:
- Add missing Fixes: tag
- Link to v1: https://lore.kernel.org/r/20250220-net-am654-nuss-kconfig-v1-1-acc813b769de@pengutronix.de
---
 drivers/net/ethernet/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 0d5a862cd78a6..3a13d60a947a8 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -99,6 +99,7 @@ config TI_K3_AM65_CPSW_NUSS
 	select NET_DEVLINK
 	select TI_DAVINCI_MDIO
 	select PHYLINK
+	select PAGE_POOL
 	select TI_K3_CPPI_DESC_POOL
 	imply PHY_TI_GMII_SEL
 	depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS

---
base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
change-id: 20250220-net-am654-nuss-kconfig-ab8e4f4e318b

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>
Re: [PATCH v2] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Posted by Michal Swiatkowski 9 months, 3 weeks ago
On Mon, Feb 24, 2025 at 06:17:16AM +0100, Sascha Hauer wrote:
> am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> selected to avoid linker errors. This is missing since the driver
> started to use page_pool helpers in 8acacc40f733 ("net: ethernet:
> ti: am65-cpsw: Add minimal XDP support")
> 
> Fixes: 8acacc40f733 ("net: ethernet: ti: am65-cpsw: Add minimal XDP support")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Changes in v2:
> - Add missing Fixes: tag
> - Link to v1: https://lore.kernel.org/r/20250220-net-am654-nuss-kconfig-v1-1-acc813b769de@pengutronix.de
> ---
>  drivers/net/ethernet/ti/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 0d5a862cd78a6..3a13d60a947a8 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -99,6 +99,7 @@ config TI_K3_AM65_CPSW_NUSS
>  	select NET_DEVLINK
>  	select TI_DAVINCI_MDIO
>  	select PHYLINK
> +	select PAGE_POOL
>  	select TI_K3_CPPI_DESC_POOL
>  	imply PHY_TI_GMII_SEL
>  	depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS
> 
> ---
> base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
> change-id: 20250220-net-am654-nuss-kconfig-ab8e4f4e318b
> 
> Best regards,
> -- 
> Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>