[PATCH 0/6] Add support for RK3588 DisplayPort Controller

Andy Yan posted 6 patches 9 months, 3 weeks ago
There is a newer version of this series
.../display/rockchip/rockchip,dw-dp.yaml      |  150 ++
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi |   30 +
.../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   30 +
.../boot/dts/rockchip/rk3588s-coolpi-4b.dts   |   37 +
drivers/gpu/drm/bridge/synopsys/Kconfig       |    7 +
drivers/gpu/drm/bridge/synopsys/Makefile      |    1 +
drivers/gpu/drm/bridge/synopsys/dw-dp.c       | 2155 +++++++++++++++++
drivers/gpu/drm/rockchip/Kconfig              |    7 +
drivers/gpu/drm/rockchip/Makefile             |    1 +
drivers/gpu/drm/rockchip/dw_dp-rockchip.c     |  162 ++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |    1 +
drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |    1 +
include/drm/bridge/dw_dp.h                    |   19 +
13 files changed, 2601 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
create mode 100644 drivers/gpu/drm/bridge/synopsys/dw-dp.c
create mode 100644 drivers/gpu/drm/rockchip/dw_dp-rockchip.c
create mode 100644 include/drm/bridge/dw_dp.h
[PATCH 0/6] Add support for RK3588 DisplayPort Controller
Posted by Andy Yan 9 months, 3 weeks ago
From: Andy Yan <andy.yan@rock-chips.com>


There are two DW DPTX based DisplayPort Controller on rk3588 which
are compliant with the DisplayPort Specification Version 1.4 with
the following features:

* DisplayPort 1.4a
* Main Link: 1/2/4 lanes
* Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps
* AUX channel 1Mbps
* Single Stream Transport(SST)
* Multistream Transport (MST)
*Type-C support (alternate mode)
* HDCP 2.2, HDCP 1.3
* Supports up to 8/10 bits per color component
* Supports RBG, YCbCr4:4:4, YCbCr4:2:2, YCbCr4:2:0
* Pixel clock up to 594MHz
* I2S, SPDIF audio interface

The current version of this patch series only supports basic display outputs.
I conducted tests in 1080p and 4K@60 YCbCr4:2:0 modes; the ALT/Type-C mode
hasn't been tested yet, but I suspect it will likely work. HDCP and audio
features remain unimplemented. For RK3588, it's only support SST, while in
the upcoming RK3576, it can support MST output.


Andy Yan (6):
  dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller
  drm/bridge: synopsys: Add DW DPTX Controller support library
  drm/rockchip: Add RK3588 DPTX output support
  arm64: dts: rockchip: Add DP0 for rk3588
  arm64: dts: rockchip: Add DP1 for rk3588
  arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B

 .../display/rockchip/rockchip,dw-dp.yaml      |  150 ++
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi |   30 +
 .../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   30 +
 .../boot/dts/rockchip/rk3588s-coolpi-4b.dts   |   37 +
 drivers/gpu/drm/bridge/synopsys/Kconfig       |    7 +
 drivers/gpu/drm/bridge/synopsys/Makefile      |    1 +
 drivers/gpu/drm/bridge/synopsys/dw-dp.c       | 2155 +++++++++++++++++
 drivers/gpu/drm/rockchip/Kconfig              |    7 +
 drivers/gpu/drm/rockchip/Makefile             |    1 +
 drivers/gpu/drm/rockchip/dw_dp-rockchip.c     |  162 ++
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |    1 +
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |    1 +
 include/drm/bridge/dw_dp.h                    |   19 +
 13 files changed, 2601 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
 create mode 100644 drivers/gpu/drm/bridge/synopsys/dw-dp.c
 create mode 100644 drivers/gpu/drm/rockchip/dw_dp-rockchip.c
 create mode 100644 include/drm/bridge/dw_dp.h

-- 
2.34.1

Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller
Posted by Piotr Oniszczuk 9 months, 2 weeks ago

> Wiadomość napisana przez Andy Yan <andyshrk@163.com> w dniu 23 lut 2025, o godz. 12:30:
> 
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> 
> There are two DW DPTX based DisplayPort Controller on rk3588 which
> are compliant with the DisplayPort Specification Version 1.4 with
> the following features:
> 
> * DisplayPort 1.4a
> * Main Link: 1/2/4 lanes
> * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps
> * AUX channel 1Mbps
> * Single Stream Transport(SST)
> * Multistream Transport (MST)
> *Type-C support (alternate mode)
> * HDCP 2.2, HDCP 1.3
> * Supports up to 8/10 bits per color component
> * Supports RBG, YCbCr4:4:4, YCbCr4:2:2, YCbCr4:2:0
> * Pixel clock up to 594MHz
> * I2S, SPDIF audio interface
> 
> The current version of this patch series only supports basic display outputs.
> I conducted tests in 1080p and 4K@60 YCbCr4:2:0 modes; the ALT/Type-C mode
> hasn't been tested yet, but I suspect it will likely work. HDCP and audio
> features remain unimplemented. For RK3588, it's only support SST, while in
> the upcoming RK3576, it can support MST output.
> 

Andy,

Is tis series enough to get usbc1/dp1 working as video output ?
(assuming i will add necessary code in dt) 

rock5-itx has second hdmi port using usbc1/dp1 lanes 2,3 to ra620 dp->hdmi converter

is it worth to play with this or it is too early?
 
Re:Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller
Posted by Andy Yan 9 months, 2 weeks ago
Hi Piotr,

在 2025-03-01 04:30:33,"Piotr Oniszczuk" <piotr.oniszczuk@gmail.com> 写道:
>
>
>> Wiadomość napisana przez Andy Yan <andyshrk@163.com> w dniu 23 lut 2025, o godz. 12:30:
>> 
>> From: Andy Yan <andy.yan@rock-chips.com>
>> 
>> 
>> There are two DW DPTX based DisplayPort Controller on rk3588 which
>> are compliant with the DisplayPort Specification Version 1.4 with
>> the following features:
>> 
>> * DisplayPort 1.4a
>> * Main Link: 1/2/4 lanes
>> * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps
>> * AUX channel 1Mbps
>> * Single Stream Transport(SST)
>> * Multistream Transport (MST)
>> *Type-C support (alternate mode)
>> * HDCP 2.2, HDCP 1.3
>> * Supports up to 8/10 bits per color component
>> * Supports RBG, YCbCr4:4:4, YCbCr4:2:2, YCbCr4:2:0
>> * Pixel clock up to 594MHz
>> * I2S, SPDIF audio interface
>> 
>> The current version of this patch series only supports basic display outputs.
>> I conducted tests in 1080p and 4K@60 YCbCr4:2:0 modes; the ALT/Type-C mode
>> hasn't been tested yet, but I suspect it will likely work. HDCP and audio
>> features remain unimplemented. For RK3588, it's only support SST, while in
>> the upcoming RK3576, it can support MST output.
>> 
>
>Andy,
>
>Is tis series enough to get usbc1/dp1 working as video output ?
>(assuming i will add necessary code in dt) 
>
>rock5-itx has second hdmi port using usbc1/dp1 lanes 2,3 to ra620 dp->hdmi converter
>
>is it worth to play with this or it is too early?

I think you could give it a try if it using the Standard DP(non-ALT mode) port for output. 
Since I don't currently have a development board with DP1 output available, I haven't been
able to test it yet. As for the Type-C Alternate Mode output, some patches are still required 
I'll  send it with V2 tomorrow or next week.
Feel free to let me know if If you encounter any issues。


> 
Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller
Posted by Piotr Oniszczuk 9 months, 2 weeks ago

> Wiadomość napisana przez Andy Yan <andyshrk@163.com> w dniu 1 mar 2025, o godz. 13:24:
> 
> 
> Hi Piotr,
> 
>> 
>> is it worth to play with this or it is too early?
> 
> I think you could give it a try if it using the Standard DP(non-ALT mode) port for output. 
> Since I don't currently have a development board with DP1 output available, I haven't been
> able to test it yet. As for the Type-C Alternate Mode output, some patches are still required 
> I'll  send it with V2 tomorrow or next week.
> Feel free to let me know if If you encounter any issues。
> 

Andy,
I added dp1 enablement in rock5 itx like this: https://gist.github.com/warpme/bddf75912193f57724c49216d5d85d4a
Unfortunately it not works.
For /sys/kernel/debug/dri/0/state - pls see above link…
I’m not sure: do i missed something in dt or rather issue issue  is in dp code...

FYI: schematic: https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf