crypto: octeontxs -: Remove unused function otx_cpt_eng_grp_has_eng_type

[PATCH] crypto: octeontxs -: Remove unused function otx_cpt_eng_grp_has_eng_type

Posted by linux@treblig.org 11 months, 2 weeks ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

otx_cpt_eng_grp_has_eng_type() was added in 2020 by
commit d9110b0b01ff ("crypto: marvell - add support for OCTEON TX CPT
engine")
but has remained unused.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c | 11 -----------
 drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h |  2 --
 2 files changed, 13 deletions(-)

diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
index c4250e5fcf8f..9472798678f9 100644
--- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
+++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
@@ -505,17 +505,6 @@ int otx_cpt_uc_supports_eng_type(struct otx_cpt_ucode *ucode, int eng_type)
 }
 EXPORT_SYMBOL_GPL(otx_cpt_uc_supports_eng_type);
 
-int otx_cpt_eng_grp_has_eng_type(struct otx_cpt_eng_grp_info *eng_grp,
-				 int eng_type)
-{
-	struct otx_cpt_engs_rsvd *engs;
-
-	engs = find_engines_by_type(eng_grp, eng_type);
-
-	return (engs != NULL ? 1 : 0);
-}
-EXPORT_SYMBOL_GPL(otx_cpt_eng_grp_has_eng_type);
-
 static void print_ucode_info(struct otx_cpt_eng_grp_info *eng_grp,
 			     char *buf, int size)
 {
diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
index 8620ac87a447..df79ee416c0d 100644
--- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
+++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
@@ -174,7 +174,5 @@ int otx_cpt_try_create_default_eng_grps(struct pci_dev *pdev,
 void otx_cpt_set_eng_grps_is_rdonly(struct otx_cpt_eng_grps *eng_grps,
 				    bool is_rdonly);
 int otx_cpt_uc_supports_eng_type(struct otx_cpt_ucode *ucode, int eng_type);
-int otx_cpt_eng_grp_has_eng_type(struct otx_cpt_eng_grp_info *eng_grp,
-				 int eng_type);
 
 #endif /* __OTX_CPTPF_UCODE_H */
-- 
2.48.1

Re: [PATCH] crypto: octeontxs -: Remove unused function otx_cpt_eng_grp_has_eng_type

Posted by Dr. David Alan Gilbert 11 months, 2 weeks ago

NAK - let me unbreak that subject line...

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> otx_cpt_eng_grp_has_eng_type() was added in 2020 by
> commit d9110b0b01ff ("crypto: marvell - add support for OCTEON TX CPT
> engine")
> but has remained unused.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c | 11 -----------
>  drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h |  2 --
>  2 files changed, 13 deletions(-)
> 
> diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
> index c4250e5fcf8f..9472798678f9 100644
> --- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
> +++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
> @@ -505,17 +505,6 @@ int otx_cpt_uc_supports_eng_type(struct otx_cpt_ucode *ucode, int eng_type)
>  }
>  EXPORT_SYMBOL_GPL(otx_cpt_uc_supports_eng_type);
>  
> -int otx_cpt_eng_grp_has_eng_type(struct otx_cpt_eng_grp_info *eng_grp,
> -				 int eng_type)
> -{
> -	struct otx_cpt_engs_rsvd *engs;
> -
> -	engs = find_engines_by_type(eng_grp, eng_type);
> -
> -	return (engs != NULL ? 1 : 0);
> -}
> -EXPORT_SYMBOL_GPL(otx_cpt_eng_grp_has_eng_type);
> -
>  static void print_ucode_info(struct otx_cpt_eng_grp_info *eng_grp,
>  			     char *buf, int size)
>  {
> diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
> index 8620ac87a447..df79ee416c0d 100644
> --- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
> +++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.h
> @@ -174,7 +174,5 @@ int otx_cpt_try_create_default_eng_grps(struct pci_dev *pdev,
>  void otx_cpt_set_eng_grps_is_rdonly(struct otx_cpt_eng_grps *eng_grps,
>  				    bool is_rdonly);
>  int otx_cpt_uc_supports_eng_type(struct otx_cpt_ucode *ucode, int eng_type);
> -int otx_cpt_eng_grp_has_eng_type(struct otx_cpt_eng_grp_info *eng_grp,
> -				 int eng_type);
>  
>  #endif /* __OTX_CPTPF_UCODE_H */
> -- 
> 2.48.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/