RDMA/mana_ib: Ensure variable err is initialized

[PATCH] RDMA/mana_ib: Ensure variable err is initialized

Posted by Kees Bakker 9 months, 3 weeks ago

In the function mana_ib_gd_create_dma_region if there are no dma blocks
to process the variable `err` remains uninitialized.

Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Kees Bakker <kees@ijzerbout.nl>
---
 drivers/infiniband/hw/mana/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
index 114ca8c509ce..eda9c5b971de 100644
--- a/drivers/infiniband/hw/mana/main.c
+++ b/drivers/infiniband/hw/mana/main.c
@@ -384,7 +384,7 @@ static int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct ib_umem
 	unsigned int tail = 0;
 	u64 *page_addr_list;
 	void *request_buf;
-	int err;
+	int err = 0;
 
 	gc = mdev_to_gc(dev);
 	hwc = gc->hwc.driver_data;
-- 
2.48.1

Re: [PATCH] RDMA/mana_ib: Ensure variable err is initialized

Posted by Leon Romanovsky 9 months, 3 weeks ago

On Fri, 21 Feb 2025 20:39:03 +0100, Kees Bakker wrote:
> In the function mana_ib_gd_create_dma_region if there are no dma blocks
> to process the variable `err` remains uninitialized.
> 
> 

Applied, thanks!

[1/1] RDMA/mana_ib: Ensure variable err is initialized
      https://git.kernel.org/rdma/rdma/c/be35a3127d6096

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>