1. Patchew
  2. linux
  3. View series

[PATCH] spi: spidev: Add compatible for LWE's btt device

Lukasz Majewski posted 1 patch 9 months, 3 weeks ago
There is a newer version of this series
drivers/spi/spidev.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] spi: spidev: Add compatible for LWE's btt device
Posted by Lukasz Majewski 9 months, 3 weeks ago 
The Liebherr's BTT devices are using spidev to communicate via
SPI to monitoring devices. Extend compatibles to allow proper
DTS description.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 58ae4304fdab..ceaccc5cf8f5 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -707,6 +707,7 @@ static const struct spi_device_id spidev_spi_ids[] = {
 	{ .name = /* dh */ "dhcom-board" },
 	{ .name = /* elgin */ "jg10309-01" },
 	{ .name = /* lineartechnology */ "ltc2488" },
+	{ .name = /* lwe */ "btt" },
 	{ .name = /* lwn */ "bk4" },
 	{ .name = /* lwn */ "bk4-spi" },
 	{ .name = /* menlo */ "m53cpld" },
@@ -738,6 +739,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
 	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
 	{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
+	{ .compatible = "lwe,btt", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4-spi", .data = &spidev_of_check },
 	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
-- 
2.39.5
Re: [PATCH] spi: spidev: Add compatible for LWE's btt device
Posted by Mark Brown 9 months, 3 weeks ago 
On Fri, Feb 21, 2025 at 04:56:44PM +0100, Lukasz Majewski wrote:
> The Liebherr's BTT devices are using spidev to communicate via
> SPI to monitoring devices. Extend compatibles to allow proper
> DTS description.

This is fine but we need a bindings document update too
(trivial-devices.yaml should be fine I think).
Re: [PATCH] spi: spidev: Add compatible for LWE's btt device
Posted by Lukasz Majewski 8 months, 3 weeks ago 
Hi Mark,

> On Fri, Feb 21, 2025 at 04:56:44PM +0100, Lukasz Majewski wrote:
> > The Liebherr's BTT devices are using spidev to communicate via
> > SPI to monitoring devices. Extend compatibles to allow proper
> > DTS description.  
> 
> This is fine but we need a bindings document update too
> (trivial-devices.yaml should be fine I think).

I've just resend the update for trival-devices.yaml.
https://lore.kernel.org/linux-devicetree/20250326140930.2587775-1-lukma@denx.de/T/#u

Hopefully you can pull it soon.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Re: [PATCH] spi: spidev: Add compatible for LWE's btt device
Posted by Mark Brown 8 months, 3 weeks ago 
On Wed, Mar 26, 2025 at 05:42:28PM +0100, Lukasz Majewski wrote:
> > On Fri, Feb 21, 2025 at 04:56:44PM +0100, Lukasz Majewski wrote:

> > This is fine but we need a bindings document update too
> > (trivial-devices.yaml should be fine I think).

> I've just resend the update for trival-devices.yaml.
> https://lore.kernel.org/linux-devicetree/20250326140930.2587775-1-lukma@denx.de/T/#u

> Hopefully you can pull it soon.

I would have expected the two updates to go together...
[PATCH v2] spi: spidev: Add compatible for LWE's btt device
Posted by Lukasz Majewski 8 months, 3 weeks ago 
The Liebherr's BTT devices are using spidev to communicate via
SPI to monitoring devices. Extend compatibles to allow proper
DTS description.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Changes for v2:
- Use 'lwn' vendor prefix instead of 'lwe' (as the former one is already
  well used in Linux sources).
---
 drivers/spi/spidev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 6108959c28d9..2568240490fa 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -708,6 +708,7 @@ static const struct spi_device_id spidev_spi_ids[] = {
 	{ .name = /* elgin */ "jg10309-01" },
 	{ .name = /* gocontroll */ "moduline-module-slot"},
 	{ .name = /* lineartechnology */ "ltc2488" },
+	{ .name = /* lwn */ "btt" },
 	{ .name = /* lwn */ "bk4" },
 	{ .name = /* lwn */ "bk4-spi" },
 	{ .name = /* menlo */ "m53cpld" },
@@ -740,6 +741,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "elgin,jg10309-01", .data = &spidev_of_check },
 	{ .compatible = "gocontroll,moduline-module-slot", .data = &spidev_of_check},
 	{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
+	{ .compatible = "lwn,btt", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4-spi", .data = &spidev_of_check },
 	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
-- 
2.39.5
Re: [PATCH v2] spi: spidev: Add compatible for LWE's btt device
Posted by Mark Brown 8 months, 3 weeks ago 
On Wed, Mar 26, 2025 at 06:24:45PM +0100, Lukasz Majewski wrote:

> Changes for v2:
> - Use 'lwn' vendor prefix instead of 'lwe' (as the former one is already
>   well used in Linux sources).

Are you sure?

Note also that as previously mentioned I expect to see a binding
document update too which doesn't appear to be here.

Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.
Re: [PATCH v2] spi: spidev: Add compatible for LWE's btt device
Posted by Lukasz Majewski 8 months, 3 weeks ago 
Hi Mark,

> On Wed, Mar 26, 2025 at 06:24:45PM +0100, Lukasz Majewski wrote:
> 
> > Changes for v2:
> > - Use 'lwn' vendor prefix instead of 'lwe' (as the former one is
> > already well used in Linux sources).  
> 
> Are you sure?

Yes, the lwn is already present for a quite few years for this company.
The lwe is just the different branch.

> 
> Note also that as previously mentioned I expect to see a binding
> document update too which doesn't appear to be here.
> 

I've just send it to be accepted to trivial-devices.yaml

> Please don't send new patches in reply to old patches or serieses,
> this makes it harder for both people and tools to understand what is
> going on - it can bury things in mailboxes and make it difficult to
> keep track of what current patches are, both for the new patches and
> the old ones.

Ok, I thought that it would be the opposite - that you would see v2 as
the reply to the old one - especially that the change is just a single
letter.



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Re: [PATCH v2] spi: spidev: Add compatible for LWE's btt device
Posted by Mark Brown 8 months, 3 weeks ago 
On Wed, Mar 26, 2025 at 06:45:53PM +0100, Lukasz Majewski wrote:
> > On Wed, Mar 26, 2025 at 06:24:45PM +0100, Lukasz Majewski wrote:

> > Note also that as previously mentioned I expect to see a binding
> > document update too which doesn't appear to be here.

> I've just send it to be accepted to trivial-devices.yaml

As previously mentioned you should send the bindings update along with
the driver code.

> > Please don't send new patches in reply to old patches or serieses,
> > this makes it harder for both people and tools to understand what is
> > going on - it can bury things in mailboxes and make it difficult to
> > keep track of what current patches are, both for the new patches and
> > the old ones.

> Ok, I thought that it would be the opposite - that you would see v2 as
> the reply to the old one - especially that the change is just a single
> letter.

That's exactly the problem.
Re: [PATCH v2] spi: spidev: Add compatible for LWE's btt device
Posted by Lukasz Majewski 8 months, 3 weeks ago 
Hi Mark,

> On Wed, Mar 26, 2025 at 06:45:53PM +0100, Lukasz Majewski wrote:
> > > On Wed, Mar 26, 2025 at 06:24:45PM +0100, Lukasz Majewski wrote:  
> 
> > > Note also that as previously mentioned I expect to see a binding
> > > document update too which doesn't appear to be here.  
> 
> > I've just send it to be accepted to trivial-devices.yaml  
> 
> As previously mentioned you should send the bindings update along with
> the driver code.

Ok, so first shall be the patch 0001, which updates
trivial-devices.yaml and then 0002, with changes for spidev (this
patch).

> 
> > > Please don't send new patches in reply to old patches or serieses,
> > > this makes it harder for both people and tools to understand what
> > > is going on - it can bury things in mailboxes and make it
> > > difficult to keep track of what current patches are, both for the
> > > new patches and the old ones.  
> 
> > Ok, I thought that it would be the opposite - that you would see v2
> > as the reply to the old one - especially that the change is just a
> > single letter.  
> 
> That's exactly the problem.

Ok. I will not use --in-reply-to= switch.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.