LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING_GEN

[PATCH] LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING_GEN

Posted by Bibo Mao 9 months, 4 weeks ago

Option HAVE_VIRT_CPU_ACCOUNTING_GEN is selected by default in kconfig file
arch/Kconfig. It is meaningless in file arch/loongarch/Kconfig, and on the
contrast it may bring out misunderstanding. Here remove it on arch
specified kconfig file.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 arch/loongarch/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index 2b8bd27a852f..7fd5708fe14a 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -175,7 +175,6 @@ config LOONGARCH
 	select HAVE_STACKPROTECTOR
 	select HAVE_SYSCALL_TRACEPOINTS
 	select HAVE_TIF_NOHZ
-	select HAVE_VIRT_CPU_ACCOUNTING_GEN if !SMP
 	select IRQ_FORCED_THREADING
 	select IRQ_LOONGARCH_CPU
 	select LOCK_MM_AND_FIND_VMA
-- 
2.39.3

Re: [PATCH] LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING_GEN

Posted by Huacai Chen 9 months, 3 weeks ago

Hi, Bibo,

On Fri, Feb 21, 2025 at 3:32 PM Bibo Mao <maobibo@loongson.cn> wrote:
>
> Option HAVE_VIRT_CPU_ACCOUNTING_GEN is selected by default in kconfig file
> arch/Kconfig. It is meaningless in file arch/loongarch/Kconfig, and on the
> contrast it may bring out misunderstanding. Here remove it on arch
> specified kconfig file.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>  arch/loongarch/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 2b8bd27a852f..7fd5708fe14a 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -175,7 +175,6 @@ config LOONGARCH
>         select HAVE_STACKPROTECTOR
>         select HAVE_SYSCALL_TRACEPOINTS
>         select HAVE_TIF_NOHZ
> -       select HAVE_VIRT_CPU_ACCOUNTING_GEN if !SMP
Please see 01f135506e2ed0403512 ("powerpc/32: select
HAVE_VIRT_CPU_ACCOUNTING_GEN"). Now HAVE_VIRT_CPU_ACCOUNTING_GEN is
available on both 32BIT and 64BIT, so I think a better solution is
unconditionally select HAVE_VIRT_CPU_ACCOUNTING_GEN which is
convenient for the upcoming LoongArch32.





Huacai

>         select IRQ_FORCED_THREADING
>         select IRQ_LOONGARCH_CPU
>         select LOCK_MM_AND_FIND_VMA
> --
> 2.39.3
>
>

Re: [PATCH] LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING_GEN

Posted by bibo mao 9 months, 3 weeks ago


On 2025/2/21 下午9:42, Huacai Chen wrote:
> Hi, Bibo,
> 
> On Fri, Feb 21, 2025 at 3:32 PM Bibo Mao <maobibo@loongson.cn> wrote:
>>
>> Option HAVE_VIRT_CPU_ACCOUNTING_GEN is selected by default in kconfig file
>> arch/Kconfig. It is meaningless in file arch/loongarch/Kconfig, and on the
>> contrast it may bring out misunderstanding. Here remove it on arch
>> specified kconfig file.
>>
>> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>> ---
>>   arch/loongarch/Kconfig | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
>> index 2b8bd27a852f..7fd5708fe14a 100644
>> --- a/arch/loongarch/Kconfig
>> +++ b/arch/loongarch/Kconfig
>> @@ -175,7 +175,6 @@ config LOONGARCH
>>          select HAVE_STACKPROTECTOR
>>          select HAVE_SYSCALL_TRACEPOINTS
>>          select HAVE_TIF_NOHZ
>> -       select HAVE_VIRT_CPU_ACCOUNTING_GEN if !SMP
> Please see 01f135506e2ed0403512 ("powerpc/32: select
> HAVE_VIRT_CPU_ACCOUNTING_GEN"). Now HAVE_VIRT_CPU_ACCOUNTING_GEN is
> available on both 32BIT and 64BIT, so I think a better solution is
> unconditionally select HAVE_VIRT_CPU_ACCOUNTING_GEN which is
> convenient for the upcoming LoongArch32.
I have no idea about LoongArch32 which is talked about years, however 
there is never actual code posted and no detailed plan. All about 
LoongArch32 is talking on the paper.

Regards
Bibo Mao
> 
> 
> 
> 
> 
> Huacai
> 
>>          select IRQ_FORCED_THREADING
>>          select IRQ_LOONGARCH_CPU
>>          select LOCK_MM_AND_FIND_VMA
>> --
>> 2.39.3
>>
>>