[PATCH 0/3] Remove nvmem deadcode

linux@treblig.org posted 3 patches 9 months, 4 weeks ago
Documentation/driver-api/nvmem.rst |  23 ------
drivers/nvmem/core.c               | 126 -----------------------------
include/linux/nvmem-consumer.h     |   4 -
include/linux/nvmem-provider.h     |  24 ------
4 files changed, 177 deletions(-)
[PATCH 0/3] Remove nvmem deadcode
Posted by linux@treblig.org 9 months, 4 weeks ago
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Hi,
  This series removes some uncalled deadcode in nvmem.
The third patch probably deserves a bit closer inspection.

The first one removes nvmem_device_cell_read/write functions
that haven't been used in ~10 years.

The second removes nvmem_add/del_cell_table - again this is
removing uncalled functions; nvmem_add_cell_table is unused
after the removal of the Davinci machines.

The third one removes the remaining nvmem_cell_table code - including
a function that's called ( nvmem_add_cells_from_table ) - but
my reading is that from the previous patch there's no way for this
function to do anything active any more since the list it walks is
empty.

Build tested only.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>


Dr. David Alan Gilbert (3):
  nvmem: core: Remove unused nvmem_device_cell_(read|write)
  nvmem: core: Remove nvmem_(add|del)_cell_table
  nvmem: core: Remove remains of nvmem_cell_table

 Documentation/driver-api/nvmem.rst |  23 ------
 drivers/nvmem/core.c               | 126 -----------------------------
 include/linux/nvmem-consumer.h     |   4 -
 include/linux/nvmem-provider.h     |  24 ------
 4 files changed, 177 deletions(-)

-- 
2.48.1
Re: [PATCH 0/3] Remove nvmem deadcode
Posted by Dr. David Alan Gilbert 8 months, 2 weeks ago
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Hi,
>   This series removes some uncalled deadcode in nvmem.
> The third patch probably deserves a bit closer inspection.
> 
> The first one removes nvmem_device_cell_read/write functions
> that haven't been used in ~10 years.
> 
> The second removes nvmem_add/del_cell_table - again this is
> removing uncalled functions; nvmem_add_cell_table is unused
> after the removal of the Davinci machines.
> 
> The third one removes the remaining nvmem_cell_table code - including
> a function that's called ( nvmem_add_cells_from_table ) - but
> my reading is that from the previous patch there's no way for this
> function to do anything active any more since the list it walks is
> empty.
> 
> Build tested only.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Hi,
  I'd appreciate a review on this series if you get a chance.

Dave (cleaning up his patch queue)
> 
> 
> Dr. David Alan Gilbert (3):
>   nvmem: core: Remove unused nvmem_device_cell_(read|write)
>   nvmem: core: Remove nvmem_(add|del)_cell_table
>   nvmem: core: Remove remains of nvmem_cell_table
> 
>  Documentation/driver-api/nvmem.rst |  23 ------
>  drivers/nvmem/core.c               | 126 -----------------------------
>  include/linux/nvmem-consumer.h     |   4 -
>  include/linux/nvmem-provider.h     |  24 ------
>  4 files changed, 177 deletions(-)
> 
> -- 
> 2.48.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/