Remove weird and needless 'return' for void APIs

[PATCH *-next 14/18] PM: wakeup: Remove needless return in three void APIs

Posted by Zijun Hu 11 months, 3 weeks ago

Remove needless 'return' in the following void APIs:

 __pm_wakeup_event()
 pm_wakeup_event()
 pm_wakeup_hard_event()

Since both the API and callee involved are void functions.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 include/linux/pm_wakeup.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h
index d501c09c60cd..51e0e8dd5f9e 100644
--- a/include/linux/pm_wakeup.h
+++ b/include/linux/pm_wakeup.h
@@ -205,17 +205,17 @@ static inline void device_set_awake_path(struct device *dev)
 
 static inline void __pm_wakeup_event(struct wakeup_source *ws, unsigned int msec)
 {
-	return pm_wakeup_ws_event(ws, msec, false);
+	pm_wakeup_ws_event(ws, msec, false);
 }
 
 static inline void pm_wakeup_event(struct device *dev, unsigned int msec)
 {
-	return pm_wakeup_dev_event(dev, msec, false);
+	pm_wakeup_dev_event(dev, msec, false);
 }
 
 static inline void pm_wakeup_hard_event(struct device *dev)
 {
-	return pm_wakeup_dev_event(dev, 0, true);
+	pm_wakeup_dev_event(dev, 0, true);
 }
 
 /**

-- 
2.34.1

Re: [PATCH *-next 14/18] PM: wakeup: Remove needless return in three void APIs

Posted by Rafael J. Wysocki 11 months, 2 weeks ago

On Fri, Feb 21, 2025 at 2:03 PM Zijun Hu <quic_zijuhu@quicinc.com> wrote:
>
> Remove needless 'return' in the following void APIs:
>
>  __pm_wakeup_event()
>  pm_wakeup_event()
>  pm_wakeup_hard_event()
>
> Since both the API and callee involved are void functions.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  include/linux/pm_wakeup.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h
> index d501c09c60cd..51e0e8dd5f9e 100644
> --- a/include/linux/pm_wakeup.h
> +++ b/include/linux/pm_wakeup.h
> @@ -205,17 +205,17 @@ static inline void device_set_awake_path(struct device *dev)
>
>  static inline void __pm_wakeup_event(struct wakeup_source *ws, unsigned int msec)
>  {
> -       return pm_wakeup_ws_event(ws, msec, false);
> +       pm_wakeup_ws_event(ws, msec, false);
>  }
>
>  static inline void pm_wakeup_event(struct device *dev, unsigned int msec)
>  {
> -       return pm_wakeup_dev_event(dev, msec, false);
> +       pm_wakeup_dev_event(dev, msec, false);
>  }
>
>  static inline void pm_wakeup_hard_event(struct device *dev)
>  {
> -       return pm_wakeup_dev_event(dev, 0, true);
> +       pm_wakeup_dev_event(dev, 0, true);
>  }
>
>  /**
>
> --

Applied as 6.15 material, thanks!