DAMOS filters do allow or reject elements of memory for given DAMOS
action only if those match the filter criterias. For elements that
don't match any DAMOS filter, 'allowing' is the default behavior. This
makes 'allow DAMOS filters' that don't have any 'reject DAMOS filter'
after them meaningless sources of overhead. The decision was made to
keep the behavior consistent with before-allow filter behavior. This,
however, only makes usage of DAMOS filters confusing and inefficient.
There is an apparently more intuitive behavior for the case. If there
is no filter at all or the last filter is a reject filter, allowing by
default.
Update the filtering logic to work in the way. Decide the default
behavior as the opposite of the last isntalled filter. If it is an
allow filter, reject by default. If it is a reject filter or no filter
is installed at all, allow by default.
Note that this is changing the old behavior. But the old behavior for
the problematic filter installation was definitely confusing,
inefficient and anyway useless. Also, the behavior has relatively
recently introduced. It is difficult to anticipate any user that
depends on the behavior. Hence this is not a user-breaking behavior
change but an obvious improvement.
SeongJae Park (9):
mm/damon/core: introduce damos->ops_filters
mm/damon/paddr: support ops_filters
mm/damon/core: support committing ops_filters
mm/damon/core: put ops-handled filters to damos->ops_filters
mm/damon/paddr: support only ops_filters
mm/damon: add default allow/reject behavior fields to struct damos
mm/damon/core: set damos_filter default allowance behavior based on
installed filters
mm/damon/paddr: respect ops_filters_default_reject
Docs/mm/damon/design: update for changed filter-default behavior
Documentation/mm/damon/design.rst | 10 ++--
include/linux/damon.h | 11 ++++
mm/damon/core.c | 87 +++++++++++++++++++++++++++++--
mm/damon/paddr.c | 8 +--
4 files changed, 102 insertions(+), 14 deletions(-)
base-commit: 3fb99e5d512f03963c91926628fcc08a96ee07f0
--
2.39.5