drivers/base/devres.c | 11 +++++ drivers/gpio/gpiolib-devres.c | 90 ++++++++++------------------------- include/linux/device.h | 38 --------------- include/linux/device/devres.h | 41 ++++++++++++++++ 4 files changed, 77 insertions(+), 103 deletions(-)
GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() calls. This mini-series is for that. The necessary prerequisites are here as well, namely: 1) moving the respective APIs to the devres.h; 2) adding a simple helper that GPIOLIB will rely on; 3) finishing the GPIOLIB conversion to the device managed action APIs. The series is based on another series that's available via immutable tag devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB tree (or Intel GPIO for the starter) with an immutable tag for the device core and others if needed. Please, review and acknowledge. Changelog v2: - dropped actually unneeded patch (Raag) - rewrote last patch as suggested (Raag) - collected tags (Raag) Link: https://lore.kernel.org/r/Z7cqCaME4LxTTBn6@black.fi.intel.com [1] Cc: Raag Jadav <raag.jadav@intel.com> Andy Shevchenko (3): devres: Move devm_*_action*() APIs to devres.h devres: Add devm_is_action_added() helper gpiolib: devres: Finish the conversion to use devm_add_action() drivers/base/devres.c | 11 +++++ drivers/gpio/gpiolib-devres.c | 90 ++++++++++------------------------- include/linux/device.h | 38 --------------- include/linux/device/devres.h | 41 ++++++++++++++++ 4 files changed, 77 insertions(+), 103 deletions(-) base-commit: 9deb15de8ca27cf9cba0d2bac53bbe37c836591b -- 2.45.1.3035.g276e886db78b
On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > calls. This mini-series is for that. The necessary prerequisites are here > as well, namely: > 1) moving the respective APIs to the devres.h; > 2) adding a simple helper that GPIOLIB will rely on; > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > The series is based on another series that's available via immutable tag > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > tree (or Intel GPIO for the starter) with an immutable tag for the device > core and others if needed. Please, review and acknowledge. Greg, I know you are busy, but do you have a chance to look at this and give your Ack if you are okay with the idea? The route is assumed to be via GPIOLIB tree. -- With Best Regards, Andy Shevchenko
On Tue, Apr 22, 2025 at 09:55:02PM +0300, Andy Shevchenko wrote: > On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > calls. This mini-series is for that. The necessary prerequisites are here > > as well, namely: > > 1) moving the respective APIs to the devres.h; > > 2) adding a simple helper that GPIOLIB will rely on; > > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > > > The series is based on another series that's available via immutable tag > > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > > tree (or Intel GPIO for the starter) with an immutable tag for the device > > core and others if needed. Please, review and acknowledge. > > Greg, I know you are busy, but do you have a chance to look at this and give > your Ack if you are okay with the idea? The route is assumed to be via GPIOLIB > tree. Looks fine to me: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Fri, Apr 25, 2025 at 03:22:33PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 22, 2025 at 09:55:02PM +0300, Andy Shevchenko wrote: > > On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > > calls. This mini-series is for that. The necessary prerequisites are here > > > as well, namely: > > > 1) moving the respective APIs to the devres.h; > > > 2) adding a simple helper that GPIOLIB will rely on; > > > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > > > > > The series is based on another series that's available via immutable tag > > > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > > > tree (or Intel GPIO for the starter) with an immutable tag for the device > > > core and others if needed. Please, review and acknowledge. > > > > Greg, I know you are busy, but do you have a chance to look at this and give > > your Ack if you are okay with the idea? The route is assumed to be via GPIOLIB > > tree. > > Looks fine to me: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thank you! Bart, are you okay to take this series? -- With Best Regards, Andy Shevchenko
On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > calls. This mini-series is for that. The necessary prerequisites are here > as well, namely: > 1) moving the respective APIs to the devres.h; > 2) adding a simple helper that GPIOLIB will rely on; > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > The series is based on another series that's available via immutable tag > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > tree (or Intel GPIO for the starter) with an immutable tag for the device > core and others if needed. Please, review and acknowledge. Bart, I know it's still 2 days left till the two-week ping time, but since we are at rc-5 and this may affect other subsystems I gently ask for your Ack/Review and I push it to my branch for GPIO (as it has dependencies which are already in my and a few other trees). -- With Best Regards, Andy Shevchenko
On Mon, Mar 3, 2025 at 11:49 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > calls. This mini-series is for that. The necessary prerequisites are here > > as well, namely: > > 1) moving the respective APIs to the devres.h; > > 2) adding a simple helper that GPIOLIB will rely on; > > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > > > The series is based on another series that's available via immutable tag > > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > > tree (or Intel GPIO for the starter) with an immutable tag for the device > > core and others if needed. Please, review and acknowledge. > > Bart, I know it's still 2 days left till the two-week ping time, but since we > are at rc-5 and this may affect other subsystems I gently ask for your > Ack/Review and I push it to my branch for GPIO (as it has dependencies which > are already in my and a few other trees). > I thought this needs an Ack from Greg or Rafael? Bart
On Mon, Mar 03, 2025 at 11:52:07AM +0100, Bartosz Golaszewski wrote: > On Mon, Mar 3, 2025 at 11:49 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Feb 20, 2025 at 06:20:25PM +0200, Andy Shevchenko wrote: > > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > > calls. This mini-series is for that. The necessary prerequisites are here > > > as well, namely: > > > 1) moving the respective APIs to the devres.h; > > > 2) adding a simple helper that GPIOLIB will rely on; > > > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > > > > > The series is based on another series that's available via immutable tag > > > devres-iio-input-pinctrl-v6.15 [1]. The idea is to route this via GPIOLIB > > > tree (or Intel GPIO for the starter) with an immutable tag for the device > > > core and others if needed. Please, review and acknowledge. > > > > Bart, I know it's still 2 days left till the two-week ping time, but since we > > are at rc-5 and this may affect other subsystems I gently ask for your > > Ack/Review and I push it to my branch for GPIO (as it has dependencies which > > are already in my and a few other trees). > > I thought this needs an Ack from Greg or Rafael? Ah, you a right, I wasn't carefully looked who gave already the tags. Greg, when you have time, can you ack this, please? -- With Best Regards, Andy Shevchenko
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Thu, 20 Feb 2025 18:20:25 +0200, Andy Shevchenko wrote:
> GPIOLIB has some open coded stuff that can be folded to the devm_*_action*()
> calls. This mini-series is for that. The necessary prerequisites are here
> as well, namely:
> 1) moving the respective APIs to the devres.h;
> 2) adding a simple helper that GPIOLIB will rely on;
> 3) finishing the GPIOLIB conversion to the device managed action APIs.
>
> [...]
Applied, thanks!
[3/3] gpiolib: devres: Finish the conversion to use devm_add_action()
https://git.kernel.org/brgl/linux/c/d1d52c6622a61a0ae8dd2bd2097b25c0f553d2f3
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Mon, Apr 28, 2025 at 09:41:52AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > On Thu, 20 Feb 2025 18:20:25 +0200, Andy Shevchenko wrote: > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > calls. This mini-series is for that. The necessary prerequisites are here > > as well, namely: > > 1) moving the respective APIs to the devres.h; > > 2) adding a simple helper that GPIOLIB will rely on; > > 3) finishing the GPIOLIB conversion to the device managed action APIs. [...] > Applied, thanks! Thanks! > [3/3] gpiolib: devres: Finish the conversion to use devm_add_action() > https://git.kernel.org/brgl/linux/c/d1d52c6622a61a0ae8dd2bd2097b25c0f553d2f3 Only one? What about the first two? -- With Best Regards, Andy Shevchenko
On Mon, Apr 28, 2025 at 9:47 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Apr 28, 2025 at 09:41:52AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > On Thu, 20 Feb 2025 18:20:25 +0200, Andy Shevchenko wrote: > > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > > calls. This mini-series is for that. The necessary prerequisites are here > > > as well, namely: > > > 1) moving the respective APIs to the devres.h; > > > 2) adding a simple helper that GPIOLIB will rely on; > > > 3) finishing the GPIOLIB conversion to the device managed action APIs. > > [...] > > > Applied, thanks! > > Thanks! > > > [3/3] gpiolib: devres: Finish the conversion to use devm_add_action() > > https://git.kernel.org/brgl/linux/c/d1d52c6622a61a0ae8dd2bd2097b25c0f553d2f3 > > Only one? What about the first two? b4 borked with the patches applied to gpio/for-next through an immutable tag but all is there, please check the tree. Bart
On Mon, Apr 28, 2025 at 09:48:37AM +0200, Bartosz Golaszewski wrote: > On Mon, Apr 28, 2025 at 9:47 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Mon, Apr 28, 2025 at 09:41:52AM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > On Thu, 20 Feb 2025 18:20:25 +0200, Andy Shevchenko wrote: > > > > GPIOLIB has some open coded stuff that can be folded to the devm_*_action*() > > > > calls. This mini-series is for that. The necessary prerequisites are here > > > > as well, namely: > > > > 1) moving the respective APIs to the devres.h; > > > > 2) adding a simple helper that GPIOLIB will rely on; > > > > 3) finishing the GPIOLIB conversion to the device managed action APIs. [...] > > > Applied, thanks! > > > > Thanks! > > > > > [3/3] gpiolib: devres: Finish the conversion to use devm_add_action() > > > https://git.kernel.org/brgl/linux/c/d1d52c6622a61a0ae8dd2bd2097b25c0f553d2f3 > > > > Only one? What about the first two? > > b4 borked with the patches applied to gpio/for-next through an > immutable tag but all is there, please check the tree. Yes, yes, sorry for the noise, and thank you! -- With Best Regards, Andy Shevchenko
© 2016 - 2025 Red Hat, Inc.