Hi Jens,
Another day in the thrilling world of cross-platform compatibility...
Alviro discovered that some Android versions are missing `aligned_alloc()`
in `<stdlib.h>`, leading to a compilation error on Termux 0.118.0:
```
cmd-discard.c:383:11: warning: call to undeclared library function \
'aligned_alloc' with type 'void *(unsigned long, unsigned long)'; ISO \
C99 and later do not support implicit function declarations \
[-Wimplicit-function-declaration]
buffer = aligned_alloc(lba_size, lba_size);
^
```
To resolve this without rewriting large portions of liburing tests,
introduce a helper function that wraps `posix_memalign()` and provides
our own `aligned_alloc()`.
While we're at it, there's a redundant double negation lurking in
`liburing.h`. Let's clean that up too.
Also, to prevent yet another round of confusion like what happened in
PR #1336, document the history of `io_uring_get_sqe()` in the header
file.
Ref: https://github.com/axboe/liburing/pull/1336
Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
Ammar Faizi (3):
liburing.h: Remove redundant double negation
liburing.h: Explain the history of `io_uring_get_sqe()`
Fix missing `aligned_alloc()` on some Android devices
examples/helpers.c | 10 ++++++++++
examples/helpers.h | 7 +++++++
examples/reg-wait.c | 2 ++
src/include/liburing.h | 21 ++++++++++++++++++++-
test/helpers.c | 10 ++++++++++
test/helpers.h | 8 ++++++++
6 files changed, 57 insertions(+), 1 deletion(-)
base-commit: 66b071d1470ae787d47d4cb8d9cb3836249baf61
--
Ammar Faizi