media: i2c: imx219: remove context around case

[PATCH] media: i2c: imx219: remove context around case

Posted by Cosmin Tanislav 9 months, 4 weeks ago

There are no longer variable declarations here, the context is useless.

Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
---
 drivers/media/i2c/imx219.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index f662c9d755114..fcd98ee54768e 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -947,10 +947,9 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
 				struct v4l2_subdev_selection *sel)
 {
 	switch (sel->target) {
-	case V4L2_SEL_TGT_CROP: {
+	case V4L2_SEL_TGT_CROP:
 		sel->r = *v4l2_subdev_state_get_crop(state, 0);
 		return 0;
-	}
 
 	case V4L2_SEL_TGT_NATIVE_SIZE:
 		sel->r.top = 0;
-- 
2.48.1

Re: [PATCH] media: i2c: imx219: remove context around case

Posted by Dave Stevenson 9 months, 4 weeks ago

Hi Cosmin

Thanks for the patch.

On Thu, 20 Feb 2025 at 14:06, Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> There are no longer variable declarations here, the context is useless.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  drivers/media/i2c/imx219.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index f662c9d755114..fcd98ee54768e 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -947,10 +947,9 @@ static int imx219_get_selection(struct v4l2_subdev *sd,
>                                 struct v4l2_subdev_selection *sel)
>  {
>         switch (sel->target) {
> -       case V4L2_SEL_TGT_CROP: {
> +       case V4L2_SEL_TGT_CROP:
>                 sel->r = *v4l2_subdev_state_get_crop(state, 0);
>                 return 0;
> -       }
>
>         case V4L2_SEL_TGT_NATIVE_SIZE:
>                 sel->r.top = 0;
> --
> 2.48.1
>