[PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()

Thorsten Blum posted 1 patch 10 months ago
sound/soc/codecs/cros_ec_codec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
Posted by Thorsten Blum 10 months ago
Remove hard-coded strings by using the str_enable_disable() helper
function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/soc/codecs/cros_ec_codec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 11e7b3f6d410..571222ec520c 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -21,6 +21,7 @@
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
 #include <linux/platform_device.h>
+#include <linux/string_choices.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
@@ -657,7 +658,7 @@ static int wov_enable_put(struct snd_kcontrol *kcontrol,
 					   (uint8_t *)&p, sizeof(p), NULL, 0);
 		if (ret) {
 			dev_err(priv->dev, "failed to %s wov\n",
-				enabled ? "enable" : "disable");
+				str_enable_disable(enabled));
 			return ret;
 		}
 
-- 
2.48.1
Re: [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
Posted by Mark Brown 9 months, 3 weeks ago
On Thu, 20 Feb 2025 13:01:01 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enable_disable() helper
> function.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
      commit: 10efa807929084a8a1c38655942a3bf83bce587a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH] ASoC: cros_ec_codec: Use str_enable_disable() helper in wov_enable_put()
Posted by Tzung-Bi Shih 10 months ago
On Thu, Feb 20, 2025 at 01:01:01PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enable_disable() helper
> function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>