[v1] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

[PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

Harshal Chaudhari posted 1 patch 9 months, 4 weeks ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

Posted by Harshal Chaudhari 9 months, 4 weeks ago

Non IP flow, with vlan tag not working as expected while
running below command for vlan-priority. fixed that.

ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0

Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 1641791a2d5b..8ed83fb98862 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -324,7 +324,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = {
 		       MVPP2_PRS_RI_VLAN_MASK),
 	/* Non IP flow, with vlan tag */
 	MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG,
-		       MVPP22_CLS_HEK_OPT_VLAN,
+		       MVPP22_CLS_HEK_TAGGED,
 		       0, 0),
 };
 
-- 
2.25.1

Re: [PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.

Posted by Jakub Kicinski 9 months, 4 weeks ago

On Thu, 20 Feb 2025 02:29:54 -0800 Harshal Chaudhari wrote:
> Non IP flow, with vlan tag not working as expected while
> running below command for vlan-priority. fixed that.
> 
> ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0

Thanks for the fix, one nit - please add a Fixes tag to the commit
message. See https://docs.kernel.org/process/submitting-patches.html
for the exact format of the Fixes tag we expect. The tag should refer
to the earliest commit where the problem could be triggered by a user.
-- 
pw-bot: cr